From owner-svn-src-all@freebsd.org  Fri May 13 15:57:57 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 15C31B3A1BD;
 Fri, 13 May 2016 15:57:57 +0000 (UTC) (envelope-from pfg@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D7A85166B;
 Fri, 13 May 2016 15:57:56 +0000 (UTC) (envelope-from pfg@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u4DFvtqY002693;
 Fri, 13 May 2016 15:57:55 GMT (envelope-from pfg@FreeBSD.org)
Received: (from pfg@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id u4DFvtRO002692;
 Fri, 13 May 2016 15:57:55 GMT (envelope-from pfg@FreeBSD.org)
Message-Id: <201605131557.u4DFvtRO002692@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: pfg set sender to pfg@FreeBSD.org
 using -f
From: "Pedro F. Giffuni" <pfg@FreeBSD.org>
Date: Fri, 13 May 2016 15:57:55 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r299682 - head/usr.sbin/i2c
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 May 2016 15:57:57 -0000

Author: pfg
Date: Fri May 13 15:57:55 2016
New Revision: 299682
URL: https://svnweb.freebsd.org/changeset/base/299682

Log:
  i2c(8): uninitialized variable (UNINIT).
  
  If i2c_opt.width is somehow zero, buf will be left uninitialized and may
  cause trouble later on. This is a followup to r299586.
  
  CID:	1331548

Modified:
  head/usr.sbin/i2c/i2c.c

Modified: head/usr.sbin/i2c/i2c.c
==============================================================================
--- head/usr.sbin/i2c/i2c.c	Fri May 13 15:32:16 2016	(r299681)
+++ head/usr.sbin/i2c/i2c.c	Fri May 13 15:57:55 2016	(r299682)
@@ -294,8 +294,10 @@ i2c_write(char *dev, struct options i2c_
 			err_msg = "error: offset malloc";
 			goto err1;
 		}
-	} else
+	} else {
 		bufsize = 0;
+		buf = NULL;
+	}
 
 	switch(i2c_opt.mode) {
 	case I2C_MODE_STOP_START: