Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 16 Aug 2014 20:31:00 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 192712] New: Minor patch update needed for devel/cvsweb3
Message-ID:  <bug-192712-13@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192712

            Bug ID: 192712
           Summary: Minor patch update needed for devel/cvsweb3
           Product: Ports Tree
           Version: Latest
          Hardware: Any
                OS: Any
            Status: Needs Triage
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: freebsd-ports-bugs@FreeBSD.org
          Reporter: freebsd@pki2.com

I do not know if this is PERL version dependent but I have had to add a minor
patch to cvsweb.cgi for some time. I updated an existing patch file which I
have included below. I am currently running PERL 5.20.

Here is my error without the additional patch:

Docs# perl -c cvsweb.cgi
"my" variable $tmp masks earlier declaration in same statement at cvsweb.cgi
line 1338.
syntax error at cvsweb.cgi line 1195, near "$v qw(hidecvsroot hidenonreadable)"
Global symbol "$v" requires explicit package name at cvsweb.cgi line 1197.
Global symbol "$v" requires explicit package name at cvsweb.cgi line 1197.
syntax error at cvsweb.cgi line 1276, near "}"
  (Might be a runaway multi-line << string starting on line 1267)
syntax error at cvsweb.cgi line 1289, near "}"
syntax error at cvsweb.cgi line 1295, near "}"
syntax error at cvsweb.cgi line 1302, near "}"
syntax error at cvsweb.cgi line 1312, near "}"
syntax error at cvsweb.cgi line 1336, near "}"
syntax error at cvsweb.cgi line 1338, near ""$tmp,v" }"
cvsweb.cgi has too many errors.
Docs# 

With the patch:

Docs# perl -c cvsweb.cgi
defined(@array) is deprecated at cvsweb.cgi line 2954.
    (Maybe you should just omit the defined()?)
cvsweb.cgi syntax OK





--- ./cvsweb.cgi.orig    2005-09-25 14:28:51.000000000 -0600
+++ ./cvsweb.cgi    2014-08-16 14:21:37.000000000 -0600
@@ -1,4 +1,4 @@
-#!/usr/bin/perl -T
+#!!!PERL!! -wT
 #
 # cvsweb - a CGI interface to CVS trees.
 #
@@ -214,7 +214,7 @@

 # == EDIT this ==
 # Locations to search for user configuration, in order:
-for (catfile($mydir, 'cvsweb.conf'), '/usr/local/etc/cvsweb/cvsweb.conf') {
+for (catfile($mydir, 'cvsweb.conf'), '!!PREFIX!!/etc/cvsweb/cvsweb.conf') {
   if (-r $_) {
     $config = $_;
     last;
@@ -1192,7 +1192,7 @@
 <legend>General options</legend>
 <input type="hidden" name="copt" value="1" />
 EOF
-    for my $v qw(hidecvsroot hidenonreadable) {
+    for my $v (qw(hidecvsroot hidenonreadable)) {
       printf(qq{<input type="hidden" name="%s" value="%s" />\n},
              $v, $input{$v} || 0);
     }

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-192712-13>