From owner-p4-projects@FreeBSD.ORG Wed Sep 12 15:01:46 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 9DF4116A419; Wed, 12 Sep 2007 15:01:46 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1937216A417 for ; Wed, 12 Sep 2007 15:01:46 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.freebsd.org (Postfix) with ESMTP id 853B413C457 for ; Wed, 12 Sep 2007 15:01:45 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 5B46145E98; Wed, 12 Sep 2007 17:01:43 +0200 (CEST) Received: from localhost (pjd.wheel.pl [10.0.1.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 1FE3445E90; Wed, 12 Sep 2007 17:01:37 +0200 (CEST) Date: Wed, 12 Sep 2007 17:00:17 +0200 From: Pawel Jakub Dawidek To: Kip Macy Message-ID: <20070912150017.GA3553@garage.freebsd.pl> References: <200709120832.l8C8WLlm085731@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mYCpIKhGyMATD0i+" Content-Disposition: inline In-Reply-To: <200709120832.l8C8WLlm085731@repoman.freebsd.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 Cc: Perforce Change Reviews Subject: Re: PERFORCE change 126330 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Sep 2007 15:01:47 -0000 --mYCpIKhGyMATD0i+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 12, 2007 at 08:32:21AM +0000, Kip Macy wrote: > http://perforce.freebsd.org/chv.cgi?CH=3D126330 >=20 > Change 126330 by kmacy@kmacy_home:ethng on 2007/09/12 08:31:36 >=20 > convert radix node head and route locks from mutexes to rwlocks [...] > rt->rt_flags |=3D RTF_LLINFO; > - callout_init_mtx(&la->la_timer, &rt->rt_mtx, > - CALLOUT_RETURNUNLOCKED); > + callout_init_rwlock(&la->la_timer, &rt->rt_lock, > + CALLOUT_RETURNUNLOCKED_RW); > =20 Kip, don't add callout_init_rwlock() to the tree. I've callout_init_lock() implemented that operates on any lock type, just like condvar(9). --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --mYCpIKhGyMATD0i+ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFG5/8BForvXbEpPzQRAixrAKCmfiwWMjpEo6sak37VM3ZRtLJagwCbBjAM hUqfYE9wrKbTDwH42CWKjFk= =phLw -----END PGP SIGNATURE----- --mYCpIKhGyMATD0i+--