From owner-freebsd-net Sat Jul 14 16:11:28 2001 Delivered-To: freebsd-net@freebsd.org Received: from kawoserv.kawo2.rwth-aachen.de (kawoserv.kawo2.RWTH-Aachen.DE [134.130.180.1]) by hub.freebsd.org (Postfix) with ESMTP id EE19537B403; Sat, 14 Jul 2001 16:11:18 -0700 (PDT) (envelope-from alex@fump.kawo2.rwth-aachen.de) Received: from fump.kawo2.rwth-aachen.de (root@fump.kawo2.rwth-aachen.de [134.130.181.148]) by kawoserv.kawo2.rwth-aachen.de (8.9.3/8.9.3) with ESMTP id BAA05623; Sun, 15 Jul 2001 01:11:17 +0200 Received: (from alex@localhost) by fump.kawo2.rwth-aachen.de (8.11.3/8.11.3) id f6ENBiu97487; Sun, 15 Jul 2001 01:11:44 +0200 (CEST) (envelope-from alex) Date: Sun, 15 Jul 2001 01:11:44 +0200 From: Alexander Langer To: Brooks Davis Cc: net@FreeBSD.ORG, audit@FreeBSD.ORG Subject: Re: review request: if_faith modernization Message-ID: <20010715011143.A97334@fump.kawo2.rwth-aachen.de> References: <20010714144147.A27610@Odin.AC.HMC.Edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010714144147.A27610@Odin.AC.HMC.Edu>; from brooks@one-eyed-alien.net on Sat, Jul 14, 2001 at 02:41:47PM -0700 X-PGP-Fingerprint: 44 28 CA 4C 46 5B D3 A8 A8 E3 BA F3 4E 60 7D 7F X-PGP-at: finger alex@big.endian.de X-Verwirrung: Dieser Header dient der allgemeinen Verwirrung. Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Thus spake Brooks Davis (brooks@one-eyed-alien.net): People. This is a good example why style fixes shouldn't happen with content fixes. I can't figure out what changed in this file: > RCS file: /home/ncvs/src/sys/modules/Makefile,v > retrieving revision 1.190 > diff -u -r1.190 Makefile > --- sys/modules/Makefile 2001/07/08 04:17:26 1.190 > +++ sys/modules/Makefile 2001/07/13 23:10:49 > diff -u -r1.6 if_faith.c > --- sys/net/if_faith.c 2001/07/05 14:42:54 1.6 > +++ sys/net/if_faith.c 2001/07/14 01:21:02 I'm just curious: Why don't you need to include sys/module.h? You don't include any other file that itself includes it, but module.h defines DECLARE_MODULE and friends, which you are using. I'm a little bit confused :-) > +#include /* XXX: Shouldn't really be required! */ Why do you include it then? :-) Haven't looked at the other stuff. Thanks Alex To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message