Date: Mon, 10 Aug 2015 02:15:23 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Koop Mast <kwm@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r286524 - in head: . etc sys/dev/drm sys/dev/drm2 Message-ID: <bneg-f17o-wny@FreeBSD.org> References: <201508091258.t79CwvGj027161@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Koop Mast <kwm@FreeBSD.org> writes: > Author: kwm (ports committer) > Date: Sun Aug 9 12:58:56 2015 > New Revision: 286524 > URL: https://svnweb.freebsd.org/changeset/base/286524 > > Log: > Add a new group named 'video' with the id of 44. And make drm create > devices in /dev/dri/ with this new group. Would 'video' group include capture devices as well? Linux seems to mix /dev/nvidia*, /dev/fb* and /dev/video* all under same group despite all of them have different attack vectors. > Modified: head/sys/dev/drm/drmP.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/dev/drm/drmP.h Sun Aug 9 12:20:22 2015 (r286523) > +++ head/sys/dev/drm/drmP.h Sun Aug 9 12:58:56 2015 (r286524) > @@ -175,7 +175,7 @@ SYSCTL_DECL(_hw_drm); >=20=20 > #define DRM_DEV_MODE (S_IRUSR|S_IWUSR|S_IRGRP|S_IWGRP) > #define DRM_DEV_UID 0 > -#define DRM_DEV_GID 0 > +#define DRM_DEV_GID 44 /* "video" group */ Why hardcode? Linux often uses udev(7) rules to assign a group which on FreeBSD can easily be translated into devd.conf(5) or devfs.rules(5). Having 'video' assigned by kernel wouldn't eliminate having to run mergemaster/etcupdate + pw groupmod on upgrade. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJVx+0cXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3b39sIAImStOX28KsCCLS6BrNsknao WyYm2D7LU+tJFgja4GKvcUld7Iw7v+NjQik11aF+rPpv7fGKe1oI5+5Hk7ttuQDt 8++AvdHj7Yl+8J0918gXBlWyYrEbdIT/7BxRlcRrgLgMiB6iFHDYbYy8heMhlwpw 9/a6ptEdTE1Ky7GqBFjtag09Wn3toI6ZdXmp/J/BBzJ6Ifvy4ILGZR9mpkK+24UY 5cyQ4UXAfFShiGqS748s+FYWEUxc3lazzP/48G7nQg6UfVfhqoFj0s66NNupuLfS 56axP72kGFErt3g5FipInTyFyD6h/D23KfzsL0lPdnFlFvQwLx5kBGKIAVmLeG8= =KBTO -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bneg-f17o-wny>