From owner-p4-projects@FreeBSD.ORG Sat Dec 4 19:50:23 2010 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id A29C61065672; Sat, 4 Dec 2010 19:50:23 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 64E37106564A for ; Sat, 4 Dec 2010 19:50:23 +0000 (UTC) (envelope-from trasz@freebsd.org) Received: from skunkworks.freebsd.org (skunkworks.freebsd.org [IPv6:2001:4f8:fff6::2d]) by mx1.freebsd.org (Postfix) with ESMTP id 50E158FC15 for ; Sat, 4 Dec 2010 19:50:23 +0000 (UTC) Received: from skunkworks.freebsd.org (localhost [127.0.0.1]) by skunkworks.freebsd.org (8.14.4/8.14.4) with ESMTP id oB4JoNGH053315 for ; Sat, 4 Dec 2010 19:50:23 GMT (envelope-from trasz@freebsd.org) Received: (from perforce@localhost) by skunkworks.freebsd.org (8.14.4/8.14.4/Submit) id oB4JoNsd053310 for perforce@freebsd.org; Sat, 4 Dec 2010 19:50:23 GMT (envelope-from trasz@freebsd.org) Date: Sat, 4 Dec 2010 19:50:23 GMT Message-Id: <201012041950.oB4JoNsd053310@skunkworks.freebsd.org> X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to trasz@freebsd.org using -f From: Edward Tomasz Napierala To: Perforce Change Reviews Precedence: bulk Cc: Subject: PERFORCE change 186633 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Dec 2010 19:50:23 -0000 http://p4web.freebsd.org/@@186633?ac=10 Change 186633 by trasz@trasz_victim on 2010/12/04 19:49:49 Update TODO. Affected files ... .. //depot/projects/soc2009/trasz_limits/TODO#32 edit Differences ... ==== //depot/projects/soc2009/trasz_limits/TODO#32 (text+ko) ==== @@ -25,9 +25,15 @@ Milestone 3: - - inheritance: different resources need to sum things up differently - - per-jail containers - - per-jail resource limits + - Consider replacing proc pointer with thread pointer in rusage_add(9) et al. + In most cases caller uses 'td->td_proc' anyway, and passing thread would + allow the HRL code to send a signal to the offending thread instead of the + offending process. + + - Do we need separate container hierarchy, or should we just drop it and use + ucred? + + - Remove CONTAINERS #ifdefs. Issues: @@ -73,8 +79,8 @@ 2. Replace single container_lock with individual per-container mutexes. - RUSAGE_NOFILE accounts for size of file descriptor table, rather than the number - of file descriptors. This shouldn't be a problem, but might be worth remembering - about. + of file descriptors. This shouldn't be a problem, but might be worth keeping + in mind. - We should have a limit for the number of files that were mmapped and then closed, and remain mapped in memory. @@ -88,7 +94,7 @@ - Bring back per-group limits. - - Some things need to be accounted for per-euid, and some per-egid. Geez. + - Some things need to be accounted for per-euid, and some per-ruid. Geez. - In maxproc limit, make sure the 'p' argument is a child process. Otherwise, if one adds rule with 'sig*' action, the signal will be sent to the parent