From owner-freebsd-ports@freebsd.org Fri Jan 13 07:09:04 2017 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4D80ECACB3C for ; Fri, 13 Jan 2017 07:09:04 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Received: from dec.sakura.ne.jp (dec.sakura.ne.jp [210.188.226.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0E9321CDA; Fri, 13 Jan 2017 07:09:03 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Received: from fortune.joker.local (123-48-19-110.dz.commufa.jp [123.48.19.110]) (authenticated bits=0) by dec.sakura.ne.jp (8.15.2/8.15.2/[SAKURA-WEB]/20080708) with ESMTPA id v0D6T6Vf013148; Fri, 13 Jan 2017 15:29:06 +0900 (JST) (envelope-from junchoon@dec.sakura.ne.jp) Date: Fri, 13 Jan 2017 15:29:06 +0900 From: Tomoaki AOKI To: freebsd-ports@freebsd.org Cc: cpm@FreeBSD.org Subject: Re: svn commit: r431339 - head/www/chromium Message-Id: <20170113152906.ce00d9633a83236996696788@dec.sakura.ne.jp> Organization: Junchoon corps X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.29; amd64-portbld-freebsd11.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 07:09:04 -0000 Hi! Can we assume all -head users update src at least "per month" basis? If so, no problem. If not, as __FreeBSD_version 1200018 came on Dec 7 15:04:22 2016 UTC at r309676, users sticking on src before this should need EXTRA_PATCHES+= ${FILESDIR}/extra-patch-libc++-old. This case, version check portion for 11 and 12 should be as below. .if ${OSVERSION} < 1200017 .if ${OSVERSION} > 1100507 && ${OSVERSION} < 1200000 EXTRA_PATCHES+= ${FILESDIR}/extra-patch-libc++-new .else EXTRA_PATCHES+= ${FILESDIR}/extra-patch-libc++-old .endif .else EXTRA_PATCHES+= ${FILESDIR}/extra-patch-libc++-new .endif This could be restored with yours after stable/12 is branched. Or making ports/UPDATING entry for -head users to update to latest base (at least after r309676) first before updating chromium could be enough. Regards. > Author: cpm > Date: Fri Jan 13 03:18:05 2017 > New Revision: 431339 > URL: https://svnweb.freebsd.org/changeset/ports/431339 > > Log: > - Wrap the entire block with OPSYS check > > Reported by: marino > MFH: 2017Q1 (blanket) > > Modified: > head/www/chromium/Makefile > > Modified: head/www/chromium/Makefile > ============================================================================== > --- head/www/chromium/Makefile Fri Jan 13 02:41:25 2017 (r431338) > +++ head/www/chromium/Makefile Fri Jan 13 03:18:05 2017 (r431339) > @@ -187,15 +187,17 @@ GN_ARGS+= is_clang=true > EXTRA_PATCHES+= ${FILESDIR}/extra-patch-clang > .endif > > -.if ${OPSYS} == FreeBSD && ${OSVERSION} < 1100508 > +.if ${OPSYS} == FreeBSD > +.if ${OSVERSION} < 1100508 > EXTRA_PATCHES+= ${FILESDIR}/extra-patch-libc++-old > .else > EXTRA_PATCHES+= ${FILESDIR}/extra-patch-libc++-new > .endif > > -.if ${OPSYS} == FreeBSD && ${OSVERSION} < 1100000 > +.if ${OSVERSION} < 1100000 > EXTRA_PATCHES+= ${FILESDIR}/extra-patch-10 > .endif > +.endif > > .if ! ${PORT_OPTIONS:MKERBEROS} > GN_ARGS+= use_kerberos=true -- Tomoaki AOKI