From owner-freebsd-stable@FreeBSD.ORG Wed Aug 16 14:31:14 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B473D16A4DE for ; Wed, 16 Aug 2006 14:31:14 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.186]) by mx1.FreeBSD.org (Postfix) with ESMTP id 085CE43D4C for ; Wed, 16 Aug 2006 14:31:13 +0000 (GMT) (envelope-from max@love2party.net) Received: from [88.64.176.231] (helo=amd64.laiers.local) by mrelayeu.kundenserver.de (node=mrelayeu5) with ESMTP (Nemesis), id 0ML25U-1GDMQJ2ffY-0007sk; Wed, 16 Aug 2006 16:31:12 +0200 From: Max Laier Organization: FreeBSD To: freebsd-stable@freebsd.org Date: Wed, 16 Aug 2006 16:31:02 +0200 User-Agent: KMail/1.9.3 References: <200608160813.21109.kees@jeremino.homeunix.net> <20060816085353.GA96738@walton.maths.tcd.ie> In-Reply-To: <20060816085353.GA96738@walton.maths.tcd.ie> X-Face: ,,8R(x[kmU]tKN@>gtH1yQE4aslGdu+2]; R]*pL,U>^H?)gW@49@wdJ`H<=?utf-8?q?=25=7D*=5FBD=0A=09U=5For=3D=5CmOZf764=26nYj=3DJYbR1PW0ud?=>|!~,,CPC.1-D$FG@0h3#'5"k{V]a~.<=?utf-8?q?mZ=7D44=23Se=7Em=0A=09Fe=7E=5C=5DX5B=5D=5Fxj?=(ykz9QKMw_l0C2AQ]}Ym8)fU MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3440592.Jkbc4Jdb4z"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200608161631.10114.max@love2party.net> X-Provags-ID: kundenserver.de abuse@kundenserver.de login:61c499deaeeba3ba5be80f48ecc83056 Cc: David Malone , Kees Plonsz Subject: Re: identity crisis of 6-STABLE in ipfw ipv6 ? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Aug 2006 14:31:14 -0000 --nextPart3440592.Jkbc4Jdb4z Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline [ Kevin reported a similar problem on monday in "Lost IPv6 with ipfw in=20 latest stable" - added to CC-list. ] On Wednesday 16 August 2006 10:53, David Malone wrote: > On Wed, Aug 16, 2006 at 08:13:20AM +0200, Kees Plonsz wrote: > > I just updated to 6-STABLE but my ipfw rules stopped working. > > It seems that "me6" is vanished into thin air. > > > > # ipfw add 7000 allow ip from me6 to me6 > > ipfw: hostname ``me6'' unknown > > I think it was broken by some missing brackets in this commit: > > http://www.freebsd.org/cgi/cvsweb.cgi/src/sbin/ipfw/ipfw2.c#rev1.88 > > Can you try the patch below? If it looks good, Max or I can commit > the fix. Whichever you prefer. Since I don't really use IPFW, I wouldn't mind to=20 get rid of the task ;) Note that I also MFCed 1.88 a couple of days ago. = =20 By the way, it's great to see actual IPv6 users ;) David's patch: Index: ipfw2.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /FreeBSD/FreeBSD-CVS/src/sbin/ipfw/ipfw2.c,v retrieving revision 1.88 diff -u -r1.88 ipfw2.c =2D-- ipfw2.c 14 May 2006 03:53:04 -0000 1.88 +++ ipfw2.c 16 Aug 2006 08:50:04 -0000 @@ -3707,10 +3707,10 @@ inet_pton(AF_INET6, host, &a)) ret =3D add_srcip6(cmd, av); /* XXX: should check for IPv4, not !IPv6 */ =2D if ((ret =3D=3D NULL) && proto =3D=3D IPPROTO_IP || strcmp(av, "me") = =3D=3D 0 || =2D !inet_pton(AF_INET6, host, &a)) + if ((ret =3D=3D NULL) && (proto =3D=3D IPPROTO_IP || strcmp(av, "me") =3D= =3D 0 || + !inet_pton(AF_INET6, host, &a))) ret =3D add_srcip(cmd, av); =2D if ((ret =3D=3D NULL) && strcmp(av, "any") !=3D 0) + if ((ret =3D=3D NULL) && (strcmp(av, "any") !=3D 0)) ret =3D cmd; > free(host); @@ -3733,10 +3733,10 @@ inet_pton(AF_INET6, host, &a)) ret =3D add_dstip6(cmd, av); /* XXX: should check for IPv4, not !IPv6 */ =2D if ((ret =3D=3D NULL) && proto =3D=3D IPPROTO_IP || strcmp(av, "me") = =3D=3D 0 || =2D !inet_pton(AF_INET6, av, &a)) + if ((ret =3D=3D NULL) && (proto =3D=3D IPPROTO_IP || strcmp(av, "me") =3D= =3D 0 || + !inet_pton(AF_INET6, av, &a))) ret =3D add_dstip(cmd, av); =2D if ((ret =3D=3D NULL) && strcmp(av, "any") !=3D 0) + if ((ret =3D=3D NULL) && (strcmp(av, "any") !=3D 0)) ret =3D cmd; =20 free(host); =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart3440592.Jkbc4Jdb4z Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQBE4ywuXyyEoT62BG0RAk+oAJ9wN0dJ+W4w9n1B/y7iIfR8FD54OgCdFHmY iPTWPWv8ju11zGh0wy4a01c= =0YPV -----END PGP SIGNATURE----- --nextPart3440592.Jkbc4Jdb4z--