From owner-svn-ports-all@FreeBSD.ORG  Sat Aug 31 21:58:45 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id A94984D7;
 Sat, 31 Aug 2013 21:58:45 +0000 (UTC)
 (envelope-from sahil@tandon.net)
Received: from cricket.hamla.org (cricket.hamla.org [206.251.255.31])
 by mx1.freebsd.org (Postfix) with ESMTP id 8F5A526A0;
 Sat, 31 Aug 2013 21:58:45 +0000 (UTC)
Received: from magnus (cpe-68-174-190-55.nyc.res.rr.com [68.174.190.55])
 by cricket.hamla.org (Postfix) with ESMTPSA id 5831A8A068;
 Sat, 31 Aug 2013 17:58:44 -0400 (EDT)
Date: Sat, 31 Aug 2013 17:58:41 -0400
From: Sahil Tandon <sahil@tandon.net>
To: Bryan Drewery <bdrewery@FreeBSD.org>
Subject: Re: svn commit: r325805 - head/Mk
Message-ID: <20130831215840.GA13875@magnus>
References: <201308311322.r7VDM2wa076581@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201308311322.r7VDM2wa076581@svn.freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Virus-Scanned: clamav-milter 0.97.3 at cricket.hamla.org
X-Virus-Status: Clean
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: Sahil Tandon <sahil@tandon.net>
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 31 Aug 2013 21:58:45 -0000

On Sat, 2013-08-31 at 13:22:02 +0000, Bryan Drewery wrote:

> Log:
>   - make fetch/checksum: If a fetched file does not match the expected size,
>     delete it and try the next site, if there is one to try.
[...]
> +					actual_size=`stat -f %z "$${file}"`; \
> +					if [ $${actual_size} -eq $${CKSIZE} ]; then \
> +						continue 2; \
> +					else \
> +						${ECHO_MSG} "=> Fetched file size mismatch (expected $${CKSIZE}, actual $${actual_size})"; \
> +						if [ $${sites_remaining} -gt 1 ]; then \
> +							${ECHO_MSG} "=> Trying next site"; \
> +							${RM} -f $${file}; \
> +						fi; \
> +					fi; \
>  				fi; \
>  			done; \
>  			${ECHO_MSG} "=> Couldn't fetch it - please try to retrieve this";\

I have not had time to properly investigate, but could the above explain
the following behavior?  Or, perhaps I've messed up something in my
local environment.  Sorry for the line-wraps:

  sahil@mirage [/usr/ports/mail/postfix-current] % sudo make makesum
  ===>  License IPL10 accepted by the user
  ===>  Found saved configuration for postfix-current-2.11.20130825,4
  ===>   postfix-current-2.11.20130825,4 depends on file:
  /usr/local/sbin/pkg - found
  => postfix-2.11-20130825.tar.gz doesn't seem to exist in
  /usr/ports/distfiles/postfix.
  => Attempting to fetch
  ftp://ftp.porcupine.org/mirrors/postfix-release/experimental/postfix-2.11-20130825.tar.gz
  postfix-2.11-20130825.tar.gz                  100% of 3866 kB  910
  kBps
  [: -eq: argument expected
  => Fetched file size mismatch (expected , actual 3959547)
  => Trying next site

This only happens if the distfile does not already exist (and therefore
needs to be fetched), and I 'make makesum'.  Apparently, CKSIZE is
undefined.  Notably, if I 'make fetch' first, and then 'make makesum',
there is no problem.

-- 
Sahil Tandon