From owner-cvs-all  Mon Feb 25  7:26:16 2002
Delivered-To: cvs-all@freebsd.org
Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42])
	by hub.freebsd.org (Postfix) with ESMTP
	id 295AB37B41A; Mon, 25 Feb 2002 07:25:48 -0800 (PST)
Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.12.2/8.12.2) with ESMTP id g1PFPigS035553;
	Mon, 25 Feb 2002 18:25:45 +0300 (MSK)
	(envelope-from ache@pobrecita.freebsd.ru)
Received: (from ache@localhost)
	by pobrecita.freebsd.ru (8.12.2/8.12.2/Submit) id g1PFPh9k035552;
	Mon, 25 Feb 2002 18:25:43 +0300 (MSK)
Date: Mon, 25 Feb 2002 18:25:42 +0300
From: "Andrey A. Chernov" <ache@nagual.pp.ru>
To: Maxim Sobolev <sobomax@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org,
	hackers@FreeBSD.org
Subject: Re: <sys/types.h> or not <sys/types.h>? [Was: cvs commit: src/include grp.h]
Message-ID: <20020225152541.GA35289@nagual.pp.ru>
References: <200202251355.g1PDtmb35078@freefall.freebsd.org> <20020225140030.GD33818@nagual.pp.ru> <3C7A458F.427FFF8A@FreeBSD.org> <20020225142352.GA34378@nagual.pp.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20020225142352.GA34378@nagual.pp.ru>
User-Agent: Mutt/1.3.27i
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Mon, Feb 25, 2002 at 17:23:53 +0300, Andrey A. Chernov wrote:
> Your initial fix was incorrect, but intention was right. <grp.h> should
> declare gid_t by itself. Sample quotes included below.
> 
> >From IEEE P1003.1 Draft 7:
> 
> NAME
> 8332 grp.h.group structure
> 8342 The gid_t type shall be defined as described in <sys/types.h>.
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I mean that the fix with less header pollution will be something 
like:

#ifndef _GID_T_DECLARED
typedef ...
#define _GID_T_DECLARED
#endif

in _both_ <grp.h> and <sys/types.h> (you need to include <machine/ansi.h> 
in <grp.h> in anycase)

But for simpler solution your fix is enough.

-- 
Andrey A. Chernov
http://ache.pp.ru/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message