From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Jun 21 17:50:02 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D5949106568B for ; Sat, 21 Jun 2008 17:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id BF0608FC16 for ; Sat, 21 Jun 2008 17:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m5LHo1Ub003635 for ; Sat, 21 Jun 2008 17:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m5LHo13I003634; Sat, 21 Jun 2008 17:50:01 GMT (envelope-from gnats) Resent-Date: Sat, 21 Jun 2008 17:50:01 GMT Resent-Message-Id: <200806211750.m5LHo13I003634@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Michael Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 874C61065677 for ; Sat, 21 Jun 2008 17:44:50 +0000 (UTC) (envelope-from freebsdports@bindone.de) Received: from mail.bindone.de (mail.bindone.de [80.190.134.51]) by mx1.freebsd.org (Postfix) with SMTP id F3D5B8FC13 for ; Sat, 21 Jun 2008 17:44:49 +0000 (UTC) (envelope-from freebsdports@bindone.de) Received: (qmail 78624 invoked by uid 0); 21 Jun 2008 17:44:48 -0000 Message-Id: <20080621174448.78623.qmail@mail.bindone.de> Date: 21 Jun 2008 17:44:48 -0000 From: Michael To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: shaun@FreeBSD.org Subject: ports/124841: [PATCH] devel/zthread: Fix signature in BlockingQueue.h X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jun 2008 17:50:03 -0000 >Number: 124841 >Category: ports >Synopsis: [PATCH] devel/zthread: Fix signature in BlockingQueue.h >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Jun 21 17:50:00 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Michael Gmelin >Release: FreeBSD 6.2-RELEASE-p3 i386 >Organization: /bin/done digital solutions GmbH >Environment: System: FreeBSD bombat.bindone.de 6.2-RELEASE-p3 FreeBSD 6.2-RELEASE-p3 #24: Wed May 16 20:01:05 CEST 2007 >Description: Two patches, one to fix a signed to unsigned comparison in Barrier.h and more importantly a fix of the signature of the overloaded bool BlockingQueue::add(item, timeout) member function in BlockingQueue.h, which rendered using the feature impossible. Since my previous attempts to contact Eric about other patches were not successful and therefore I do not expect new releases of ZThread anytime in the near future, I suggest fixing this in the port skeleton. Portlint complained about an old README.html in the port as well, you might consider removing this when applying these patches. Added file(s): - files/patch-include_zthread_Barrier.h - files/patch-include_zthread_BlockingQueue.h Port maintainer (shaun@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.77 >How-To-Repeat: >Fix: --- zthread-2.3.2_1.patch begins here --- diff -ruN --exclude=CVS /usr/ports/devel/zthread.orig/Makefile /usr/ports/devel/zthread/Makefile --- /usr/ports/devel/zthread.orig/Makefile Sat Apr 21 17:17:27 2007 +++ /usr/ports/devel/zthread/Makefile Sat Jun 21 19:21:00 2008 @@ -7,6 +7,7 @@ PORTNAME= zthread PORTVERSION= 2.3.2 +PORTREVISION= 1 CATEGORIES= devel MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} MASTER_SITE_SUBDIR= ${PORTNAME} diff -ruN --exclude=CVS /usr/ports/devel/zthread.orig/files/patch-include_zthread_Barrier.h /usr/ports/devel/zthread/files/patch-include_zthread_Barrier.h --- /usr/ports/devel/zthread.orig/files/patch-include_zthread_Barrier.h Thu Jan 1 01:00:00 1970 +++ /usr/ports/devel/zthread/files/patch-include_zthread_Barrier.h Sat Jun 21 19:24:26 2008 @@ -0,0 +1,20 @@ +--- include/zthread/Barrier.h.orig Sun Mar 13 06:23:00 2005 ++++ include/zthread/Barrier.h Sat Jun 21 17:31:14 2008 +@@ -150,7 +150,7 @@ + + } else { + +- int myGeneration = _generation; ++ unsigned int myGeneration = _generation; + + try { + +@@ -251,7 +251,7 @@ + + } else { + +- int myGeneration = _generation; ++ unsigned int myGeneration = _generation; + + try { + diff -ruN --exclude=CVS /usr/ports/devel/zthread.orig/files/patch-include_zthread_BlockingQueue.h /usr/ports/devel/zthread/files/patch-include_zthread_BlockingQueue.h --- /usr/ports/devel/zthread.orig/files/patch-include_zthread_BlockingQueue.h Thu Jan 1 01:00:00 1970 +++ /usr/ports/devel/zthread/files/patch-include_zthread_BlockingQueue.h Sat Jun 21 19:19:17 2008 @@ -0,0 +1,11 @@ +--- include/zthread/BlockingQueue.h.orig Sun Mar 13 03:04:18 2005 ++++ include/zthread/BlockingQueue.h Sat Jun 21 17:31:14 2008 +@@ -83,7 +83,7 @@ + /** + * @see Queue::add(const T& item, unsigned long timeout) + */ +- virtual bool add(T item, unsigned long timeout) { ++ virtual bool add(const T& item, unsigned long timeout) { + + try { + --- zthread-2.3.2_1.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: