Date: Tue, 17 Aug 2021 12:43:42 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 257910] security/p5-IO-Socket-SSL: Update to 2.072 Message-ID: <bug-257910-7788-MCBpMpMsQO@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-257910-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-257910-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D257910 Nuno Teixeira <eduardo@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eduardo@FreeBSD.org --- Comment #1 from Nuno Teixeira <eduardo@FreeBSD.org> --- Created attachment 227281 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D227281&action= =3Dedit "git diff" to update the port reformated Hello, I'm thinking that this port could have some small fixes and formating: 1. Use DISTVERSION instead of PORTVERSION: --- Example 2. Using DISTVERSION When the version only contains numbers separated by dots, dashes or underscores, use DISTVERSION. https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-nami= ng --- 2. Alphatical order in RUN_DEPENDS: --- -RUN_DEPENDS=3D p5-Net-SSLeay>=3D1.59:security/p5-Net-SSLeay \ - p5-Mozilla-CA>=3D20130114:www/p5-Mozilla-CA +RUN_DEPENDS=3D p5-Mozilla-CA>=3D20130114:www/p5-Mozilla-CA \ + p5-Net-SSLeay>=3D1.59:security/p5-Net-SSLeay --- with p5-'M'ozilla-CA first and p5-'N'et-SSLeay next 3. Add and extra tab in +OPTIONS_DEFINE so it can be aligned with variables bellow: --- -OPTIONS_DEFINE=3D EXAMPLES IDN IPV6 +OPTIONS_DEFINE=3D EXAMPLES IDN IPV6 --- I've used portfmt tool to check Makefile formating but sometimes it could l= ead to mistakes. With this port I think it worked fine. Please check my patch and tell me if it is ok. Thanks 3. Add an extra tab --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-257910-7788-MCBpMpMsQO>