From owner-freebsd-bugs@freebsd.org Tue Jul 31 02:11:17 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CAA26106AAAC for ; Tue, 31 Jul 2018 02:11:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 67EC7741CD for ; Tue, 31 Jul 2018 02:11:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 2C66C106AAAB; Tue, 31 Jul 2018 02:11:17 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1B000106AAAA for ; Tue, 31 Jul 2018 02:11:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AFC53741C3 for ; Tue, 31 Jul 2018 02:11:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 094C3942D for ; Tue, 31 Jul 2018 02:11:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w6V2BF5N012664 for ; Tue, 31 Jul 2018 02:11:15 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w6V2BFf8012654 for bugs@FreeBSD.org; Tue, 31 Jul 2018 02:11:15 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 230220] UFS: the freezing ioctl (i.e.UFSSUSPEND) causes panic or EBUSY Date: Tue, 31 Jul 2018 02:11:16 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: decui@microsoft.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2018 02:11:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230220 --- Comment #2 from Dexuan Cui --- (In reply to Dexuan Cui from comment #0) If there is only one mount point (i.e. /), I can't reproduce the panic. The panic only happens after I mount /dev/da2p1 on /mnt. The panic is caused by the failure of the KASSERT ffs_susp_ioctl(): case UFSSUSPEND: fsidp =3D (fsid_t *)addr; mp =3D vfs_getvfs(fsidp); if (mp =3D=3D NULL) { error =3D ENOENT; break; } error =3D vfs_busy(mp, 0); vfs_rel(mp); if (error !=3D 0) break; error =3D ffs_susp_suspend(mp); if (error !=3D 0) { vfs_unbusy(mp); break; } error =3D devfs_set_cdevpriv(mp, ffs_susp_dtor); KASSERT(error =3D=3D 0, ("devfs_set_cdevpriv failed")); break; When the UFSSUSPEND ioctl is called for the second time, devfs_set_cdevpriv= () returns EBUSY. --=20 You are receiving this mail because: You are the assignee for the bug.=