From owner-svn-src-all@freebsd.org  Fri Apr 21 11:58:39 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 94A6CD47191;
 Fri, 21 Apr 2017 11:58:39 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from mail109.syd.optusnet.com.au (mail109.syd.optusnet.com.au
 [211.29.132.80]) by mx1.freebsd.org (Postfix) with ESMTP id 5AC0F99C;
 Fri, 21 Apr 2017 11:58:38 +0000 (UTC)
 (envelope-from brde@optusnet.com.au)
Received: from besplex.bde.org (c122-106-153-191.carlnfd1.nsw.optusnet.com.au
 [122.106.153.191])
 by mail109.syd.optusnet.com.au (Postfix) with ESMTPS id 45E2ED66337;
 Fri, 21 Apr 2017 21:58:32 +1000 (AEST)
Date: Fri, 21 Apr 2017 21:58:30 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Rick Macklem <rmacklem@uoguelph.ca>
cc: Bruce Evans <brde@optusnet.com.au>, Rick Macklem <rmacklem@freebsd.org>, 
 "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject: Re: svn commit: r317240 - head/sys/fs/nfs
In-Reply-To: <YTXPR01MB01896B8154F83A3CFFA31FB9DD1A0@YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM>
Message-ID: <20170421215452.R2416@besplex.bde.org>
References: <201704210150.v3L1ofgl014509@repo.freebsd.org>,
 <20170421141623.A1141@besplex.bde.org>
 <YTXPR01MB01896B8154F83A3CFFA31FB9DD1A0@YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Optus-CM-Score: 0
X-Optus-CM-Analysis: v=2.2 cv=AYLBJzfG c=1 sm=1 tr=0
 a=Tj3pCpwHnMupdyZSltBt7Q==:117 a=Tj3pCpwHnMupdyZSltBt7Q==:17
 a=kj9zAlcOel0A:10 a=p2sOvODb33Ro217gv_8A:9 a=CjuIK1q_8ugA:10
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Apr 2017 11:58:39 -0000

On Fri, 21 Apr 2017, Rick Macklem wrote:

> Yes, I agree that hardcoded values are bad.
> Thanks for pointing out the constants in sys/conf.h, I can use those instead.
> sys/conf.h does not have an entry for "nogroup", which is what has been used
> by nfsuserd since it was written.
>
> Is adding an entry to sys/conf.h for GID_NOGROUP ok to do?

It is currently mostly for device configuration, but the user/group defines
in it are already misplaced (for convenience) so a couple more wouldn't hurt.

> rick
> ps: I hope you don't mind the top post...

I prefer not.

Bruce