From owner-svn-src-head@FreeBSD.ORG Mon Feb 16 08:38:44 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6EC5998B; Mon, 16 Feb 2015 08:38:44 +0000 (UTC) Received: from mx1.sbone.de (bird.sbone.de [46.4.1.90]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 1EDF3259; Mon, 16 Feb 2015 08:38:43 +0000 (UTC) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id BC85E25D3891; Mon, 16 Feb 2015 08:38:39 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 5F3BAC77043; Mon, 16 Feb 2015 08:38:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id 23cPWvbyV_rh; Mon, 16 Feb 2015 08:38:37 +0000 (UTC) Received: from [IPv6:fde9:577b:c1a9:4410:75b7:e357:a2dd:8cdb] (unknown [IPv6:fde9:577b:c1a9:4410:75b7:e357:a2dd:8cdb]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 78326C77042; Mon, 16 Feb 2015 08:38:36 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: svn commit: r278828 - head/sys/netinet6 From: "Bjoern A. Zeeb" In-Reply-To: <20150216033656.GD15484@FreeBSD.org> Date: Mon, 16 Feb 2015 08:38:04 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: <114163CC-5599-4A12-92B6-5B106EF86263@FreeBSD.org> References: <201502160112.t1G1CKd0074570@svn.freebsd.org> <20150216013000.GB15484@FreeBSD.org> <8750BD23-1384-4065-8368-C332F6683814@FreeBSD.org> <20150216033656.GD15484@FreeBSD.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.2070.6) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 08:38:44 -0000 > On 16 Feb 2015, at 03:36 , Gleb Smirnoff wrote: >=20 > On Mon, Feb 16, 2015 at 01:34:09AM +0000, Bjoern A. Zeeb wrote: > B>=20 > B> > On 16 Feb 2015, at 01:30 , Gleb Smirnoff = wrote: > B> >=20 > B> > On Mon, Feb 16, 2015 at 01:25:05AM +0000, Bjoern A. Zeeb wrote: > B> > B>=20 > B> > B> > On 16 Feb 2015, at 01:12 , Gleb Smirnoff = wrote: > B> > B> >=20 > B> > B> > Author: glebius > B> > B> > Date: Mon Feb 16 01:12:20 2015 > B> > B> > New Revision: 278828 > B> > B> > URL: https://svnweb.freebsd.org/changeset/base/278828 > B> > B> >=20 > B> > B> > Log: > B> > B> > Factor out ip6_deletefraghdr() function, to be shared = between IPv6 > B> > B> > stack and pf(4). > B> > B> >=20 > B> > B> > Submitted by: Kristof Provost > B> > B> > Reviewed by: ae > B> > B> > Differential Revision: D1764 > B> > B> >=20 > B> > B> > Modified: > B> > B> > head/sys/netinet6/frag6.c > B> > B> > head/sys/netinet6/ip6_output.c > B> > B>=20 > B> > B> Why did it have to move file? > B>=20 > B> But the new function is in ip6_output and the consumer stays in = frag6 and will be in pf? So the new function moved to a different file = without consumer rather than just on top of the old function? Keep = code logically together seems to make more sense to me. What am I = missing? >=20 > You are right. I somehow misread it as function being in frag6.c and = consumer > in ip6_output.c. Will fix. Thanks!