From owner-freebsd-acpi@FreeBSD.ORG Tue Apr 21 19:03:02 2009 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 13480106566B for ; Tue, 21 Apr 2009 19:03:02 +0000 (UTC) (envelope-from nate@root.org) Received: from nlpi001.prodigy.net (nlpi001.sbcis.sbc.com [207.115.36.30]) by mx1.freebsd.org (Postfix) with ESMTP id D5AAE8FC1A for ; Tue, 21 Apr 2009 19:03:01 +0000 (UTC) (envelope-from nate@root.org) Received: from [10.0.5.18] (ppp-71-139-6-115.dsl.snfc21.pacbell.net [71.139.6.115]) (authenticated bits=0) by nlpi001.prodigy.net (8.13.8 smtpauth/dk/map_regex/8.13.8) with ESMTP id n3LJ2unp015886; Tue, 21 Apr 2009 14:02:58 -0500 Message-ID: <49EE1863.1000306@root.org> Date: Tue, 21 Apr 2009 12:02:59 -0700 From: Nate Lawson User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Andriy Gapon References: <49DE1F8B.2080400@earthlink.net> <49DE2E6D.5050001@icyb.net.ua> <49DE596E.2050406@earthlink.net> <49DEFF53.1040306@icyb.net.ua> <49DF7A1C.90009@root.org> <20090418043432.O34434@sola.nimnet.asn.au> <49E8D824.1000001@root.org> <20090417200726.GG3014@deviant.kiev.zoral.com.ua> <49E8E6E3.40304@root.org> <49EDFAED.4030606@icyb.net.ua> In-Reply-To: <49EDFAED.4030606@icyb.net.ua> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: sclark46@earthlink.net, freebsd-acpi@freebsd.org, Ian Smith Subject: Re: 6.x acpi powerbutton X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2009 19:03:02 -0000 Andriy Gapon wrote: > on 17/04/2009 23:30 Nate Lawson said the following: >> Sure. Perhaps Andriy will pick up this task after reworking the suspend >> path code for S5? It seems related. > > Oh I think that this would be a much easier and independent task. > Right now I have the following in my local tree, but I think that it might be > better to limit the message to S5 state only, so that people with laptops do not > complain about extra spam. > > diff --git a/sys/dev/acpica/acpi.c b/sys/dev/acpica/acpi.c > index 8a592d2..f3e0c1f 100644 > --- a/sys/dev/acpica/acpi.c > +++ b/sys/dev/acpica/acpi.c > @@ -2169,6 +2169,8 @@ acpi_ReqSleepState(struct acpi_softc *sc, int state) > if (state < ACPI_STATE_S1 || state > ACPI_STATE_S5) > return (EINVAL); > > + printf("acpi: request to enter S%d sleep state\n", state); > + > /* S5 (soft-off) should be entered directly with no waiting. */ > if (state == ACPI_STATE_S5) { > if (ACPI_SUCCESS(acpi_EnterSleepState(sc, state))) > I don't think that's what they're asking for. The normal shutdown process creates log entries, even if destined for poweroff. For example, shutdown -p will log before powering off. acpi_ReqSleepState() can come through /dev/apm, sysctl, etc. as well as the power button handler. They are interested in the initiator of the event, the button itself. So you'd be adding a printf to the power button handler, "power button pressed". Then the normal shutdown messages would be logged but they would know the reason. Remember that with sysctl, you can configure different events to button mappings. So the power button could be used to initiate a suspend, for example. -- Nate