Date: Sat, 11 Mar 2017 14:19:26 -0500 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Ian Lepore <ian@freebsd.org> Cc: freebsd-arm@freebsd.org Subject: Re: Odd-looking serial console prompt on RPI2 Message-ID: <20170311191926.le5ort7zdinxwppz@mutt-hbsd> In-Reply-To: <1489259878.40576.62.camel@freebsd.org> References: <20170302020116.GA98466@bluezbox.com> <1488420309.60166.32.camel@freebsd.org> <CA%2B7sy7Bv=-2mx2MJP18ZnbNp2yO2hKukw=KALn711txaxsk=rg@mail.gmail.com> <1488664965.69705.24.camel@freebsd.org> <20170307190937.r7n45xj67tnhevv4@mutt-hbsd> <20170307192918.2garie2ow6lzekg7@mutt-hbsd> <20170311174940.bze4k7ndjdemmu4l@mutt-hbsd> <1489255444.40576.57.camel@freebsd.org> <20170311180947.ro5obisuaemvudkp@mutt-hbsd> <1489259878.40576.62.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--i57yfzzai7uts5vr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 11, 2017 at 12:17:58PM -0700, Ian Lepore wrote: > On Sat, 2017-03-11 at 13:09 -0500, Shawn Webb wrote: > > On Sat, Mar 11, 2017 at 11:04:04AM -0700, Ian Lepore wrote: > > >=20 > > > On Sat, 2017-03-11 at 12:49 -0500, Shawn Webb wrote: > > > >=20 > > > > On Tue, Mar 07, 2017 at 02:29:18PM -0500, Shawn Webb wrote: > > > > >=20 > > > > >=20 > > > > > On Tue, Mar 07, 2017 at 02:09:37PM -0500, Shawn Webb wrote: > > > > > >=20 > > > > > >=20 > > > > > > On Sat, Mar 04, 2017 at 03:02:45PM -0700, Ian Lepore wrote: > > > > > > >=20 > > > > > > >=20 > > > > > > > The bugs should be fixed as of r314682. ?It looks like the > > > > > > > bugs > > > > > > > have > > > > > > > long been in the pl011 driver, but were masked by having a > > > > > > > fifo > > > > > > > depth > > > > > > > of 1 byte -- it all sorta worked by accident previously. > > > > > > Thanks for the fix! But it looks to be only partial. When I > > > > > > connect to > > > > > > the serial console via either cu or screen, I don't get > > > > > > corrupted > > > > > > text, > > > > > > but no keypresses are registered. Hitting enter at the login > > > > > > prompt does > > > > > > absolutely nothing. I'm at the latest commit of > > > > > > hardened/current/master > > > > > > on HardenedBSD for both the RPI3 and my laptop. > > > > > >=20 > > > > > > I'm using this serial cable from Adafruit: > > > > > > https://www.adafruit.com/product/954 > > > > > It looks like I had a bad cable. Sorry for the line noise. > > > > > Switching to > > > > > a different cable worked. > > > > Looks like the problem is back, but manifest in a different way. > > > > Screenshot: > > > >=20 > > > > https://goo.gl/photos/XYx6v1jCTVCGrnhd6 > > > >=20 > > > > Thanks, > > > >=20 > > > I wonder if rpi3 needs the same smaller-fifo fix as a 32-bit rpi. > > > ?Just > > > to test that theory, can you see if the attached patch fixes > > > problem? > > > ?If it does, I'll figure out how to detect rpi3 at runtime and set > > > the > > > sizes properly. > > >=20 > > > -- Ian > > >=20 > > > Index: sys/dev/uart/uart_dev_pl011.c > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > --- sys/dev/uart/uart_dev_pl011.c (revision 314917) > > > +++ sys/dev/uart/uart_dev_pl011.c (working copy) > > > @@ -464,7 +464,7 @@ uart_pl011_bus_probe(struct uart_softc *sc) > > > ? is_bcm2835 =3D ofw_bus_is_compatible(sc->sc_dev, > > > "brcm,bcm2835-pl011") || > > > ? ????ofw_bus_is_compatible(sc->sc_dev, "broadcom,bcm2835- > > > uart"); > > > ?#else > > > - is_bcm2835 =3D false; > > > + is_bcm2835 =3D true; > > > ?#endif > > > ? hwrev =3D __uart_getreg(&sc->sc_bas, UART_PIDREG_2) >> 4; > > > ? if (hwrev <=3D 2 || is_bcm2835) { > > Sure. I'll report back either tonight or tomorrow. > >=20 > > Thanks, > >=20 >=20 > Actually, I think a proper solution will be something like the attached > patch. ?After some spelunking on the web I think the rpi3 fifos are the > smaller size because the fdt data contains the linux-style workaround > (which overrides the primecell periphid value with fdt data). ?This > patch looks for that in addition to looking for the rpi compatible > strings (still required to handle old-style freebsd fdt data). >=20 > -- Ian Cool. I'll give that patch a shot soon. Thanks a lot! --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --i57yfzzai7uts5vr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAljETbsACgkQaoRlj1JF bu6ZDg//To8zE+axviS5/yWwhL0tAbGp8NBLVGa2BYNENK8Cr0rffwC7CGw6BMB9 z4VTCNQiZ/nEUY0q7MZEUb0FxSyMWOvswdEgZCugmj8+soBwPUIsc9haYr48hPdN JePXi5WOex7F8dfgvigwM102H62Ggm7N1MuIisBlk8gT7mDBUj9J/OWKyF/Cnlzc fbEHjehpUA+8GIOB/kUoff4O1910cVMpIwysc5yuyXeSX7nYliWGgA9ZFrC6HgSu XG8PbxH1O/nysmYmOkhg4m4ZfA2Wfv/tHh7XFT9ypYRiFFvBOzKpNrrnbn62Bc6D 1TQv6Y7zV/epuKvxokHMwO7fg1dPXhNcdAdfD6d1lW79t8XxEQvXaJaYMqaHS0MJ rH8nTntwrXuN9BBwBJzflorJb4qNhlQ2TJHUZau9GabwdRmKENX/K+w1Zh7IlyKO PC7cvpyr1U3YKtjtWcnoOTD+mYeVhAJ9y6TNf81onEy0WEwl9ydaRGN4SvS1/lro pYezS0pq4ykDUe/ZgtLOm2ulJEwJXBXYsho9r9degPxmZu1sncmymKK9Xc1JsN4D 3hmXbq3Gzf+9ZmWnI8wokXFnS4HwrYDEuLd1ZyjUyc6leDRuUvcAyN/V+41AK3iI chu6Wpuhz0494JUwS3x8NX3Wg+882Lu8gX71rv00dq1PoCqkgG0= =ut3c -----END PGP SIGNATURE----- --i57yfzzai7uts5vr--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170311191926.le5ort7zdinxwppz>