Date: Tue, 27 Dec 2016 09:08:46 -0500 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Adrian Chadd <adrian@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r310624 - head/sys/net80211 Message-ID: <20161227140846.xu4f6lmsgqytuhne@mutt-hardenedbsd> In-Reply-To: <201612270610.uBR6ASrp025710@repo.freebsd.org> References: <201612270610.uBR6ASrp025710@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--dxse5plh6235ywib Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 27, 2016 at 06:10:28AM +0000, Adrian Chadd wrote: > Author: adrian > Date: Tue Dec 27 06:10:28 2016 > New Revision: 310624 > URL: https://svnweb.freebsd.org/changeset/base/310624 >=20 > Log: > [net80211] turn the default TX key configuration (for WEP) into a vap c= allback. > =20 > The ath10k firmware supports hardware WEP offload, and in native wifi m= ode > (or 802.3 ethernet mode, for that matter) the WEP key isn't actually in= cluded > in the TX payload from net80211. Instead, a separate firmware command = is issued > that sets the default TX key to be the specified key. > =20 > However, net80211 doesn't at all inform the driver layer that this is > occuring - it just "expects" to be inserting WEP header information > when doing WEP TX, even with hardware encryption. > =20 > So, to better support the newer world order, turn the default TX key as= signment > into a VAP method that can be overridden by the driver and ensure its w= rapped > in a crypto begin/end set. That way it should be correctly atomic from= the > point of view of keychanges (as long as the driver does the right thing= =2E) > =20 > It'd be nice if we passed through to the key_set call a flag that says > "also make this the default key" - that's captured here by calling the > deftxkey method after the key_set method. Maybe I can do that later. > =20 > Note: this is a net80211 ABI change, and will require a kernel+modules > recompile. Happy Holidays, etc. Hey Adrian, Thank you very much for your hard work on the wireless stack. Since this introduces an ABI change, should __FreeBSD_version be bumped? Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --dxse5plh6235ywib Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAlhidewACgkQaoRlj1JF bu5t5g//cfiAvi9JeNZ37WoRx80fonwDtUHSN+vKLrzeQBFl1yBlpD5S0CWi0nAD RbFUIWmJ/Rn9aMt9BrPWAK/TTipZVed6XT+xCBodNf8kQatQTD45CdAy+5OAUK8L txpmE8Fyh2FkOvw4p5WtkHyuYzfocZVGqP4NnJXlhQg0N38EigZTVRZkRub5j3FU xRJvz49Qn1U7YUJqoWWFLf9CHFMI2jHi65CUMNAcNA05tTw0Rng6l/vkulWThOyw 7B2cMdixfrGH64EdShgjh0uvbYrr8hAh4mHt1rXpHNejQVctU/gJRdpOEDcD8olN jYae0H2SWWECuYPu2u7fGj/K6lUPfktuIG9okqJLBDjv+m4QgK8HVZjtie7Ehj9v E1gQ+eeHWNfLbV2d8x+ezATZWd2Wl9CmLqgP/4VsvnBfV0iuURlv1c1mE0YEJOhO LodNbRx39r4N5m0kbEBk12Yk2O0dvsHnduMssJYHbU4+0kndHcOPTVhVySwC6U8H p+/vDTaGRwhbgZ6VAfQoMOkvyk60ud5ciEt89JXKMGtZlPxh6xVrG8JgRKvvZwnR 050wAggl2zo9yYceYnvOaEl+94/IdXiMo1Do2ViLj8BtBViRnjZ5tBjrUp8BPtQ+ 2mUQkNAVu/3vljkf5aBzo8PkNJjnoRSgGg5bsiGtxO/O1WOSaMg= =gumU -----END PGP SIGNATURE----- --dxse5plh6235ywib--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161227140846.xu4f6lmsgqytuhne>