From owner-freebsd-bluetooth@FreeBSD.ORG Tue Dec 1 23:25:56 2009 Return-Path: Delivered-To: freebsd-bluetooth@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4F0831065670 for ; Tue, 1 Dec 2009 23:25:56 +0000 (UTC) (envelope-from maksim.yevmenkin@gmail.com) Received: from mail-pz0-f178.google.com (mail-pz0-f178.google.com [209.85.222.178]) by mx1.freebsd.org (Postfix) with ESMTP id 25D128FC0C for ; Tue, 1 Dec 2009 23:25:55 +0000 (UTC) Received: by pzk8 with SMTP id 8so845684pzk.8 for ; Tue, 01 Dec 2009 15:25:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=/vVMRyTCG4I99uegC1IXTF4N9Qnud1rSu26xmP2/b5Y=; b=MkF4LgbwhrUyWDTT7kkux7H/J6ryV1E/1euKK4b23hJiFFG4bwszANyJwxtxUCZTDY Et3ApYRaosFQUQjyYKyQdq1WzjczO6VLm5mosesVBsSGILxEtOjt0i0J2/Tn1a1wu8er fPr95Lty6S92vVZVkiRlwwVtRKescG8hatfUM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=Tue/J/v9Zfj0hrzNgqqGvkUiSZmKqpRn46YqzG+Ve9UcgtIdR6OTXMBOEMAJ/3mzrG A2RvsDbkETbg8cQ/Mo6L8Naidy4rKi1inND8RgF4g0VDU0FSdWzeIEFnGxdvZA9gOaIc eEpx5RMcMALFFPXfgQNsIYB+2dKaGmGj0ftTc= MIME-Version: 1.0 Received: by 10.115.101.1 with SMTP id d1mr3154175wam.40.1259709955367; Tue, 01 Dec 2009 15:25:55 -0800 (PST) In-Reply-To: <1259695873.086896.28523.nullmailer@galant.ukfsn.org> References: <20091201125054.44a00147@zelz27> <1259694948.961003.27487.nullmailer@galant.ukfsn.org> <1259695873.086896.28523.nullmailer@galant.ukfsn.org> Date: Tue, 1 Dec 2009 15:25:55 -0800 Message-ID: From: Maksim Yevmenkin To: Iain Hibbert Content-Type: text/plain; charset=ISO-8859-1 Cc: freebsd-bluetooth@freebsd.org Subject: Re: obexapp patches for type-punning X-BeenThere: freebsd-bluetooth@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Using Bluetooth in FreeBSD environments List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Dec 2009 23:25:56 -0000 On Tue, Dec 1, 2009 at 11:31 AM, Iain Hibbert wrote: > Hi, > > while on the subject of obexapp, I have a patch to remove some annoying > 'type punning' compilation errors that gcc spits out that I'm not totally > sure are valid, but see below anyway.. that is why i had -fno-strict-aliasing in makefile :) > I don't understand the OBEX protocol or libopenobex enough to know if it > is possible, but the last case also removes a potential NULL dereference - > if the OBEX_ObjectGetNonHdrData() fails to recover a proper data, an error > is logged but it carries on and hdr->flags might cause a segfault? yes, i think those are good. combined patch went out in the previous email. thanks, max