From owner-freebsd-usb@FreeBSD.ORG Thu Aug 21 15:50:09 2008 Return-Path: Delivered-To: freebsd-usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8FC90106564A; Thu, 21 Aug 2008 15:50:09 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe05.swip.net [212.247.154.129]) by mx1.freebsd.org (Postfix) with ESMTP id 950F68FC1B; Thu, 21 Aug 2008 15:50:08 +0000 (UTC) (envelope-from hselasky@c2i.net) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.0 c=1 a=H3poPDSvFasA:10 a=fj6dw-CIB2gA:10 a=6MIg2jpqvhTpo/gR8GzG7Q==:17 a=nw_ldT7Q0Dlw-qXl5yYA:9 a=fzuyTjGVRBe3JV5IUCwA:7 a=RjU2Z8bJbJ1mUxWB5XXfqcYuIsEA:4 a=50e4U0PicR4A:10 Received: from [62.113.133.243] (account mc467741@c2i.net [62.113.133.243] verified) by mailfe05.swip.net (CommuniGate Pro SMTP 5.2.6) with ESMTPA id 945512004; Thu, 21 Aug 2008 17:50:06 +0200 From: Hans Petter Selasky To: Kris Kennaway Date: Thu, 21 Aug 2008 17:51:49 +0200 User-Agent: KMail/1.9.7 References: <20080818205914.GJ16977@elvis.mu.org> <20080820211644.GD16977@elvis.mu.org> <48AC983B.4020409@FreeBSD.org> In-Reply-To: <48AC983B.4020409@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200808211751.51465.hselasky@c2i.net> Cc: freebsd-usb@freebsd.org Subject: Re: usb4bsd patch review [was Re: ...] X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Aug 2008 15:50:09 -0000 Hi, > OK. Based on this review thread I think we have agreed that: > > * The ARM changes were already imported separately by warner Great. > * the sound changes will not go in since they're unrelated to USB and > there are some unresolved questions there. It sounds like there are > real bugs identified and possibly also fixed there, so I continue to > encourage you or Hans to follow up with the sound developers so the > problems can be resolved separately. Fine. > > * the newbus change is not needed (but warner liked Hans's helper > function so maybe that should be committed separately) Fine. > > * the ndis module is not complete and will not go in yet, and the > question about the above #ifdef will be resolved in the meantime > Fine. > * hans is going to work on adding back the individual drivers instead of > bundling them Fine. > > * you and hans will work on the manpages post-commit with help from the > doc guys Fine. > > Questions remaining: > > * Why is the PAGE_SHIFT change necessary? According to what Warner stated in a recent e-mail, the page PAGE_SHIFT re-definition by the NDIS is redundant and can be removed. > * The $FreeBSD$ expansion in files that were copied - will this confuse > SVN or the CVS exporter? In CVS we had to make sure not to import > expanded tags. Easiest solution is to just unexpand them. Alfred, you have to answer this. > * How much of the userland support is incomplete or in flux, and what > functionality is missing for users of the usb2 code until it is finished? The USB userland library is nearly complete. All it lacks is proper documentation: svn --username anonsvn --password anonsvn \ checkout svn://svn.turbocat.net/i4b/trunk/libusb20 The USB config utility is also starting to become finished. It will be renamed to usbconfig. Currently it is called usbview : svn --username anonsvn --password anonsvn \ checkout svn://svn.turbocat.net/i4b/trunk/usbview --HPS