From owner-svn-ports-all@FreeBSD.ORG Sun Oct 27 18:16:34 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 9EE4F2C2; Sun, 27 Oct 2013 18:16:34 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66]) by mx1.freebsd.org (Postfix) with ESMTP id 7AFCB24E9; Sun, 27 Oct 2013 18:16:34 +0000 (UTC) Received: from trevally.dhcp.nue.suse.com (charybdis-ext.suse.de [195.135.221.2]) by ainaz.pair.com (Postfix) with ESMTPSA id 9CA1F3F446; Sun, 27 Oct 2013 14:16:30 -0400 (EDT) Date: Sun, 27 Oct 2013 19:16:29 +0100 (CET) From: Gerald Pfeifer To: Pawel Pekala Subject: Re: svn commit: r331739 - in head/multimedia/bombono: . files In-Reply-To: <201310262208.r9QM8pIq066948@svn.freebsd.org> Message-ID: References: <201310262208.r9QM8pIq066948@svn.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Oct 2013 18:16:34 -0000 Hi Pawel, On Sat, 26 Oct 2013, Pawel Pekala wrote: > +MAKE_ARGS= DVDREAD_INCLUDE=${LOCALBASE}/include \ > + DVDREAD_LIBPATH=${LOCALBASE}/lib \ > + CXXFLAGS="${CXXFLAGS}" LDFLAGS="${LDFLAGS}" \ > + CC="${CC}" CXX="${CXX}" why are you doing this? CXXFLAGS, LDFLAGS, CC and CXX all should be set by default already. Checkout the following in Mk/bsd.port.mk MAKE_ENV+= PREFIX=${PREFIX} \ LOCALBASE=${LOCALBASE} \ LIBDIR="${LIBDIR}" \ CC="${CC}" CFLAGS="${CFLAGS}" \ CPP="${CPP}" CPPFLAGS="${CPPFLAGS}" \ LDFLAGS="${LDFLAGS}" \ CXX="${CXX}" CXXFLAGS="${CXXFLAGS}" \ MANPREFIX="${MANPREFIX}" Gerald