From owner-freebsd-current Tue Jan 21 3:11: 3 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4419E37B401 for ; Tue, 21 Jan 2003 03:11:02 -0800 (PST) Received: from quadric.isometry.net (pc3-oxfd2-6-cust207.oxfd.cable.ntl.com [81.103.193.207]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8A49943ED8 for ; Tue, 21 Jan 2003 03:11:01 -0800 (PST) (envelope-from robin@isometry.net) Received: from ishadow (ishadow [192.168.108.2]) by quadric.isometry.net (Postfix) with ESMTP id 75E5C7F for ; Tue, 21 Jan 2003 11:10:59 +0000 (UTC) Reply-To: From: "Robin Breathe" To: Subject: adduser(8) in 5.0-R Date: Tue, 21 Jan 2003 11:10:59 -0000 Organization: isometry.net Message-ID: <000701c2c13d$c728a250$026ca8c0@ishadow> X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook, Build 10.0.4510 Importance: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Morning all, Just a little thing I've spotted in 5.0-R which could cause grief for new users. Post-perl adduser(8) is broken with what I would term sensible passwords. i.e. those which contain special shell characters (|/`/$/etc). The fix is simple: --- /usr/src/usr.sbin/adduser/adduser.sh.original Tue Jan 21 10:18:54 2003 +++ /usr/src/usr.sbin/adduser/adduser.sh Tue Jan 21 10:36:40 2003 @@ -205,7 +205,7 @@ yes) _passwdmethod="-w yes" _passwd="-h 0" - _upasswd="echo $upass |" + _upasswd="echo '$upass' |" ;; none) _passwdmethod="-w none" Could somebody please commit this? Robin PS: This seemed so trivial that it didn't deserve a whole PR to itself... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message