From nobody Mon Dec 26 22:22:49 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ngsjt2tvRz1J8wH; Mon, 26 Dec 2022 22:22:58 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ngsjt0HhBz4KMw; Mon, 26 Dec 2022 22:22:58 +0000 (UTC) (envelope-from gerald@pfeifer.com) Authentication-Results: mx1.freebsd.org; none Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id AE48133EB7; Mon, 26 Dec 2022 17:22:51 -0500 (EST) Received: from naga.localdomain (62-47-241-209.adsl.highway.telekom.at [62.47.241.209]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id DE35933EE9; Mon, 26 Dec 2022 17:22:50 -0500 (EST) Date: Mon, 26 Dec 2022 23:22:49 +0100 (CET) From: Gerald Pfeifer To: Nuno Teixeira cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 6622ce688cfd - main - multimedia/libopenshot: Update to 0.3.0 In-Reply-To: <202212260526.2BQ5QNkY028999@gitrepo.freebsd.org> Message-ID: <8082ef57-e8b6-adc0-5587-a580ce8dbb98@pfeifer.com> References: <202212260526.2BQ5QNkY028999@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: mailmunge 3.10 on 209.68.5.143 X-Rspamd-Queue-Id: 4Ngsjt0HhBz4KMw X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:7859, ipnet:209.68.0.0/18, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Mon, 26 Dec 2022, Nuno Teixeira wrote: > .if !exists(/usr/include/omp.h) > -USES+= compiler:gcc-c++11-lib > +USES+= compiler:c++14-lang > +USE_GCC= yes > .else > -USES+= compiler:c++11-lang > +USES+= compiler:c++14-lang > .endif This sets USES+= compiler:c++14-lang in both the if-arm and the else-arm. Why not set this unconditionally then? And combining compiler:c++14-lang and USE_GCC=yes is odd; I don't think that really works. Are you sure this entire block is still necessary at all? Where would it make a difference? Gerald