Date: Mon, 26 Dec 2022 23:29:49 +0100 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: Nuno Teixeira <eduardo@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 6622ce688cfd - main - multimedia/libopenshot: Update to 0.3.0 Message-ID: <Y6ogXR2mFK%2BfqcH/@KGPE-D16> In-Reply-To: <8082ef57-e8b6-adc0-5587-a580ce8dbb98@pfeifer.com> References: <202212260526.2BQ5QNkY028999@gitrepo.freebsd.org> <8082ef57-e8b6-adc0-5587-a580ce8dbb98@pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--2bCIM1jBFcEimUZT Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline On 22-12-26 23:22:49, Gerald Pfeifer wrote: >On Mon, 26 Dec 2022, Nuno Teixeira wrote: >> .if !exists(/usr/include/omp.h) >> -USES+= compiler:gcc-c++11-lib >> +USES+= compiler:c++14-lang >> +USE_GCC= yes >> .else >> -USES+= compiler:c++11-lang >> +USES+= compiler:c++14-lang >> .endif > >This sets > USES+= compiler:c++14-lang >in both the if-arm and the else-arm. > >Why not set this unconditionally then? > >And combining compiler:c++14-lang and USE_GCC=yes is odd; I don't think >that really works. > >Are you sure this entire block is still necessary at all? Where would it >make a difference? > >Gerald Gerald is right. Moreover, USE_GCC=yes forces linking on libstdc++ which might cause runtime issues. --2bCIM1jBFcEimUZT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJkBAABCgBOFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmOqIF0wFIAAAAAAFQAS cGthLWFkZHJlc3NAZ251cGcub3JncGt1YmFqQGFub25nb3RoLnBsAAoJEHpZm4Ug g5ydUrUQAMY/9WmPqFIZpsjSytl5kggLbPvqAUk8JBg7G+JErKqw2qE8XszfMPyK t6vopBvUiRih5WSw3JKthoTVvmym7WwfG0/rzxhhd6IvYmklJxgUAuptTxJ/93Ua CXqTQNjS960CgqVolIWCxoMyoEsiN6pLjrCanhGHP3GWsRtT/Hh8nEw3AGKqCVg5 tnmhTM7QyDorTJ/PMMvAs2tNiBuqBIWGeLMkgEUoH2O0cBBYgJAXDEz2S+Ca2CDK +BHKo2ZUTVxigyV/F3nsSNTg685T4ZCM1D9803n9HEwHpPR5/T714h4bhICCQYDK vdmP8ig5Wn5Mq6qQZ+Cq7IqlC9K3is/6RLdtEkMaMPmxeCL6GaJlG/zU7TZWw/2V 5v+sHgl+YGrj12mQAdO69lKEwYC7TmQY3CaTP3KzSbnM38vFh6S5S7SJi8QzE9dR aFya3wJgWlRuQ8ZE2undHJlh3X+QzoGflvVaxGN+92GiE00Qdt45BMDyeQKdN1S5 XuvAEEUkuY4OB88aGIfJpTmqhdWV40itl75YMwJhrasfPqlqDq2YqY2ZgerB8OIA 0eaimjZcg35NTqttf2AyF212ksuZDz6RnyBbGNvdZwfFM5iRKoEvr3D/NeTvCxct riFaNOlEwM3sumzHQNv17yaZdIJkwiJXLY2RddXtGmx1NoaoCMqQ =vKkG -----END PGP SIGNATURE----- --2bCIM1jBFcEimUZT--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Y6ogXR2mFK%2BfqcH/>