Date: Tue, 1 Jan 2013 19:49:48 +0000 From: "Robert N. M. Watson" <rwatson@FreeBSD.org> To: Andrew Turner <andrew@fubar.geek.nz> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r244899 - head/sys/mips/beri Message-ID: <E0592D53-543F-41B7-A141-01CB40669337@FreeBSD.org> In-Reply-To: <20130102081746.5435db05@fubar.geek.nz> References: <201212311106.qBVB6chM016661@svn.freebsd.org> <20130102081746.5435db05@fubar.geek.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1 Jan 2013, at 19:17, Andrew Turner wrote:
>> @@ -76,6 +85,17 @@ mips_init(void)
>> {
>> int i;
>>=20
>> +#ifdef FDT
>> +#ifndef FDT_DTB_STATIC
>> +#error "mips_init with FDT requires FDT_DTB_STATIC"
>> +#endif
>> +
>> + if (OF_install(OFW_FDT, 0) =3D=3D FALSE)
>> + while (1);
>> + if (OF_init(&fdt_static_dtb) !=3D 0)
>> + while (1);
>> +#endif
>> +
>> for (i =3D 0; i < 10; i++) {
>> phys_avail[i] =3D 0;
>> }
>>=20
>>=20
>=20
> This looks like it is too late in the boot process. If you are using
> FDT you will need to use the FDT uart which is initialised in cninit.
Hi Andrew:
The current BERI low-level UART, as with several others in MIPS-space, =
has excessively intimate knowledge of the location of the console UART =
instance. Once we fix the console driver, you're right -- it will need =
to move to platform_init() or similar.
> You will also need a patch similar to the untested one attached to fix =
the build.
Thanks -- I had actually committed an identical patch to Perforce this =
morning, but failed to merge it to head. It would be nice if we didn't =
have to conditionally include headers.
Robert=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E0592D53-543F-41B7-A141-01CB40669337>