From owner-svn-src-all@FreeBSD.ORG Mon Nov 10 20:13:22 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8FB9DCF1; Mon, 10 Nov 2014 20:13:22 +0000 (UTC) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1A9E060E; Mon, 10 Nov 2014 20:13:21 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7::96f:bc74:b3c9:9d0e] (unknown [IPv6:2001:7b8:3a7:0:96f:bc74:b3c9:9d0e]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id C605CB80A; Mon, 10 Nov 2014 21:13:15 +0100 (CET) Subject: Re: svn commit: r273266 - in head: lib/libkvm sys/compat/freebsd32 sys/kern sys/sys Mime-Version: 1.0 (Mac OS X Mail 8.0 \(1990.1\)) Content-Type: multipart/signed; boundary="Apple-Mail=_60FEF507-7367-4F03-AE0B-9B5C57F9F9BD"; protocol="application/pgp-signature"; micalg=pgp-sha1 X-Pgp-Agent: GPGMail 2.5b1 From: Dimitry Andric In-Reply-To: Date: Mon, 10 Nov 2014 21:13:08 +0100 Message-Id: References: <201410181936.s9IJaCwu018930@svn.freebsd.org> <20141019032038.GA41067@onelab2.iet.unipi.it> To: Adrian Chadd X-Mailer: Apple Mail (2.1990.1) Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Luigi Rizzo , John Baldwin X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Nov 2014 20:13:22 -0000 --Apple-Mail=_60FEF507-7367-4F03-AE0B-9B5C57F9F9BD Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii I noted something similar for kgdb, when compiled with gcc: cc1: warnings being treated as errors /usr/src/gnu/usr.bin/gdb/kgdb/trgt_i386.c: In function = 'kgdb_trgt_fetch_tss': /usr/src/gnu/usr.bin/gdb/kgdb/trgt_i386.c:142: warning: comparison is = always false due to limited range of data type In gnu/usr.bin/gdb/kgdb/kgdb.h, there is: struct kthr { struct kthr *next; uintptr_t paddr; uintptr_t kaddr; uintptr_t kstack; uintptr_t pcb; int tid; int pid; u_char cpu; }; The cpu field is assigned from td.td_oncpu (which is an int) in kgdb_thr_add_procs(), so I think it should be safe to change it to an int too: Index: gnu/usr.bin/gdb/kgdb/kgdb.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- gnu/usr.bin/gdb/kgdb/kgdb.h (revision 274350) +++ gnu/usr.bin/gdb/kgdb/kgdb.h (working copy) @@ -41,7 +41,7 @@ uintptr_t pcb; int tid; int pid; - u_char cpu; + int cpu; }; extern struct kthr *curkthr; -Dimitry > On 19 Oct 2014, at 06:38, Adrian Chadd wrote: >=20 > Rebuilt, tested, committed to -HEAD. >=20 > Thanks! >=20 > -a >=20 >=20 > On 18 October 2014 20:51, Adrian Chadd wrote: >> .. actually, try this: >>=20 >> adrian@testbox1:~/work/freebsd/head/src % svn diff sys/kern/ >> Index: sys/kern/kern_intr.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- sys/kern/kern_intr.c (revision 272839) >> +++ sys/kern/kern_intr.c (working copy) >> @@ -362,8 +362,7 @@ >> { >> struct intr_event *ie; >> cpuset_t *mask; >> - u_char cpu; >> - int n; >> + int cpu, n; >>=20 >> mask =3D m; >> cpu =3D NOCPU; >> @@ -377,7 +376,7 @@ >> continue; >> if (cpu !=3D NOCPU) >> return (EINVAL); >> - cpu =3D (u_char)n; >> + cpu =3D n; >> } >> } >> ie =3D intr_lookup(irq); >>=20 >>=20 >>=20 >>=20 >> -a >=20 --Apple-Mail=_60FEF507-7367-4F03-AE0B-9B5C57F9F9BD Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.26 iEYEARECAAYFAlRhHFoACgkQsF6jCi4glqPehgCgm902ras5wndbFy/8cQvKpkeq ZbEAoO1cWl7EuyvQt+pEJHQUk3rAxlFi =TYaL -----END PGP SIGNATURE----- --Apple-Mail=_60FEF507-7367-4F03-AE0B-9B5C57F9F9BD--