Date: Mon, 2 Apr 2001 19:10:02 -0700 (PDT) From: Dima Dorfman <dima@unixfreak.org> To: freebsd-bugs@FreeBSD.org Subject: Re: misc/26306: misspelling in burncd application Message-ID: <200104030210.f332A2G61759@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR misc/26306; it has been noted by GNATS.
From: Dima Dorfman <dima@unixfreak.org>
To: otterr@telocity.com
Cc: freebsd-gnats-submit@FreeBSD.org, sos@freebsd.org
Subject: Re: misc/26306: misspelling in burncd application
Date: Mon, 02 Apr 2001 19:04:25 -0700
[ cc'd to sos, the burncd author ]
otterr@telocity.com writes:
>
> >Number: 26306
> >Category: misc
> >Synopsis: misspelling in burncd application
>
> >Description:
> When using burncd to erase a CD-RW, it echoes "eraseing CD, please wait..".
>
> >Fix:
> "eraseing" should be corrected to reflect the proper spelling: "erasing". (No
> offense to the Danes. The app makes up for it!)
Actually, it isn't a spelling error on the author's part per se. The
way it's written in the code, it's very easy to overlook this mistake
(esp. for a non-native English speaker). Just thought I'd point that
out.
Attached is a patch. It compiles, but other than that I've not tested
it (I don't have a burner).
Dima Dorfman
dima@unixfreak.org
Index: burncd.c
===================================================================
RCS file: /st/src/FreeBSD/src/usr.sbin/burncd/burncd.c,v
retrieving revision 1.12
diff -u -r1.12 burncd.c
--- burncd.c 2001/01/10 19:28:37 1.12
+++ burncd.c 2001/04/03 02:01:45
@@ -141,13 +141,17 @@
}
if (!strcmp(argv[arg], "erase") || !strcmp(argv[arg], "blank")){
int error, blank, percent;
- if (!quiet)
- fprintf(stderr, "%sing CD, please wait..\r",
- argv[arg]);
- if (!strcmp(argv[arg], "erase"))
+ char *act_ing;
+ if (!strcmp(argv[arg], "erase")) {
blank = CDR_B_ALL;
- else
+ act_ing = "erasing";
+ } else {
blank = CDR_B_MIN;
+ act_ing = "blanking";
+ }
+ if (!quiet)
+ fprintf(stderr, "%s CD, please wait..\r",
+ act_ing);
if (ioctl(fd, CDRIOCBLANK, &blank) < 0)
err(EX_IOERR, "ioctl(CDRIOCBLANK)");
@@ -156,9 +160,9 @@
error = ioctl(fd, CDRIOCGETPROGRESS, &percent);
if (percent > 0 && !quiet)
fprintf(stderr,
- "%sing CD - %d %% done"
+ "%s CD - %d %% done"
" \r",
- argv[arg], percent);
+ act_ing, percent);
if (error || percent == 100)
break;
}
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200104030210.f332A2G61759>