From owner-freebsd-ports@FreeBSD.ORG Sun Jun 24 18:06:23 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E2811065670 for ; Sun, 24 Jun 2012 18:06:23 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 0B8338FC1A for ; Sun, 24 Jun 2012 18:06:22 +0000 (UTC) Received: by obbun3 with SMTP id un3so6675347obb.13 for ; Sun, 24 Jun 2012 11:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=X5PnjcNl4D78Bk7B6HpPXekzszNRiOpQ5NYbgUTtXnI=; b=PfdfMWnHq3GAqCZ1KisjQMGMCm0eykKJCKGoqCKZB+sdleuIhfbZESZ1T4XMQfOfua ZzIZMHrhFBgkSTEy15OpBKpBJXSUegpdkzQTji5OSwJx8M2rSUT3BD5wCSsmyqc9Szbi +6lOV47gg2AmGmUgZ+kTLIOQVOeecfxRjLwfs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-gm-message-state; bh=X5PnjcNl4D78Bk7B6HpPXekzszNRiOpQ5NYbgUTtXnI=; b=h2ErChozNJhhzvukYqGtrLfJQu7fcA3sbXxBVJH52ueKfcbde/G0qDe6sCk172W79C UeuKxzFx8hU5VNzab2548dbjWM92wM8buTJJc/UFMsqbvyclFwG+eY6l7rcHLI7tZtBt XhyzfOZzZANWrXivGJOjYD1W1RjUf89q7Vb3amrsDNYQDXZfYXs0yLrpZdH807/U8NDu PBux9JGPB8fuxyM1uQlGIkRALNdSK9RECZVeidDx26EOgTrpOepYmaqCHR90MbqucqfN pgPqtMIT9CBGHg/Tq3hTZJRWjkR9vc60r3+BCe9dayROdA2l0bUBZ+yU11BPIUFEwUXS aLRw== Received: by 10.182.108.71 with SMTP id hi7mr9428657obb.21.1340561182682; Sun, 24 Jun 2012 11:06:22 -0700 (PDT) MIME-Version: 1.0 Received: by 10.182.125.70 with HTTP; Sun, 24 Jun 2012 11:05:52 -0700 (PDT) In-Reply-To: <4FE6F010.80609@FreeBSD.org> References: <4FE6F010.80609@FreeBSD.org> From: Eitan Adler Date: Sun, 24 Jun 2012 11:05:52 -0700 Message-ID: To: Doug Barton Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQnWHPFZiYTGzU4FpWbs1RYGN63Zew07PZGfawBO98IIrHRHmI25dsipp4AUUEUInYf59U9H Cc: FreeBSD ports list Subject: Re: X11BASE still in use in ports X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jun 2012 18:06:23 -0000 On 24 June 2012 03:46, Doug Barton wrote: > I noticed a failure in one of my ports today while doing an upgrade, and > was embarrassed to find that it was due to my port still using X11BASE. > That led me to do a quick grep of the tree, which seems to indicate that > there are a non-zero number of uses of it which seem to be erroneous: When the patch was committed a exp-run was done. At the time any errors found were either fixed or worked around (by manually adding a X11BASE definition to the port's makefile). > http://people.freebsd.org/~dougb/x11base-ports.txt > > Note, some of these are actually Ok, I haven't made an attempt to filter > them out yet. > > Is there any interest in cleaning these up? Should we restore the > definition of X11BASE until all of the ports that are using it are fixed? I'd rather add it locally as a workaround to each port rather than add it globally. > I'm kind of surprised by this problem, since the usual way of removing > something like this is to make sure all of the consumers have been fixed > first. Frankly, I'm surprised too, given that we (x11@) did search for consumers of the variable. -- Eitan Adler