From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Mar 11 18:30:10 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7B0F11065672 for ; Sun, 11 Mar 2012 18:30:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 3E1768FC15 for ; Sun, 11 Mar 2012 18:30:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q2BIUA2N006371 for ; Sun, 11 Mar 2012 18:30:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q2BIUAxZ006368; Sun, 11 Mar 2012 18:30:10 GMT (envelope-from gnats) Resent-Date: Sun, 11 Mar 2012 18:30:10 GMT Resent-Message-Id: <201203111830.q2BIUAxZ006368@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Corey Halpin Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 63F0C1065672 for ; Sun, 11 Mar 2012 18:26:36 +0000 (UTC) (envelope-from chalpin@cs.wisc.edu) Received: from sabe.cs.wisc.edu (sabe.cs.wisc.edu [128.105.6.20]) by mx1.freebsd.org (Postfix) with ESMTP id 223B58FC08 for ; Sun, 11 Mar 2012 18:26:35 +0000 (UTC) Received: from spiff.home.crhalpin.org (eagleheights-105-18.resnet.wisc.edu [146.151.105.18]) (authenticated bits=0) by sabe.cs.wisc.edu (8.14.1/8.14.1) with ESMTP id q2BIQZ0r000379 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 11 Mar 2012 13:26:35 -0500 Received: from hobbes.home.crhalpin.org (hobbes.home.crhalpin.org [192.168.1.2]) by spiff.home.crhalpin.org (Postfix) with ESMTP id 195291CC19 for ; Sun, 11 Mar 2012 13:26:30 -0500 (CDT) Received: from hobbes.home.crhalpin.org (localhost [127.0.0.1]) by hobbes.home.crhalpin.org (8.14.5/8.14.5) with ESMTP id q2BIQTT8008815 for ; Sun, 11 Mar 2012 13:26:29 -0500 (CDT) (envelope-from crhalpin@hobbes.home.crhalpin.org) Received: (from crhalpin@localhost) by hobbes.home.crhalpin.org (8.14.5/8.14.5/Submit) id q2BIQTFh008814; Sun, 11 Mar 2012 13:26:29 -0500 (CDT) (envelope-from crhalpin) Message-Id: <201203111826.q2BIQTFh008814@hobbes.home.crhalpin.org> Date: Sun, 11 Mar 2012 13:26:29 -0500 (CDT) From: Corey Halpin To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/165938: sysutils/dvdisaster: Fix segfault/drive detection failure on 9.x X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Corey Halpin List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Mar 2012 18:30:10 -0000 >Number: 165938 >Category: ports >Synopsis: sysutils/dvdisaster: Fix segfault/drive detection failure on 9.x >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Sun Mar 11 18:30:09 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Corey Halpin >Release: FreeBSD 9.0-RELEASE i386 >Organization: >Environment: >Description: Environment: System: FreeBSD hobbes.home.crhalpin.org 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:15:25 UTC 2012 root@obrian.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 Description: On FreeBSD 9.x, sysutils/dvdisaster fails to detect drives (due to changes in CAM), sometimes segfaulting. How-To-Repeat: Run dvdisaster on a 9.x system. Fix: The attached patch fixes the problem, and should also resolve PRs 164464 and 165787. diff -ruN /usr/ports/sysutils/dvdisaster/Makefile dvdisaster/Makefile --- /usr/ports/sysutils/dvdisaster/Makefile 2012-03-02 00:10:57.000000000 -0600 +++ dvdisaster/Makefile 2012-03-11 13:16:04.000000000 -0500 @@ -7,6 +7,7 @@ PORTNAME= dvdisaster PORTVERSION= 0.72.3 +PORTREVISION= 1 CATEGORIES= sysutils MASTER_SITES= SF \ http://dvdisaster.net/downloads/ diff -ruN /usr/ports/sysutils/dvdisaster/files/patch-fix_drive_detection dvdisaster/files/patch-fix_drive_detection --- /usr/ports/sysutils/dvdisaster/files/patch-fix_drive_detection 1969-12-31 18:00:00.000000000 -0600 +++ dvdisaster/files/patch-fix_drive_detection 2012-03-11 13:02:54.000000000 -0500 @@ -0,0 +1,28 @@ +--- /dev/shm/dvdisaster-0.72.3/scsi-freebsd.c 2011-10-02 20:32:04.000000000 +0200 ++++ scsi-freebsd.c 2012-03-11 18:19:09.000000000 +0100 +@@ -177,7 +177,6 @@ + Stop("illegal data_mode: %d", data_mode); + } + +- + cam_fill_csio(&ccb->csio, 1, NULL, flags, CAM_TAG_ACTION_NONE,//MSG_SIMPLE_Q_TAG, + buf, size, sizeof(struct scsi_sense_data), cdb_size, + 120*1000); /* 120 secs timeout */ +@@ -194,7 +193,7 @@ + + /* Extract sense data */ + +- memcpy(sense, &(ccb->csio.sense_data), sizeof(struct scsi_sense_data)); ++ memcpy(sense, &(ccb->csio.sense_data), sizeof(Sense)); + + if((ccb->ccb_h.status & CAM_STATUS_MASK) == CAM_REQ_CMP) + return 0; +@@ -204,8 +203,6 @@ + status = ccb->csio.scsi_status; + + return -1; +- +- + } + + #endif /* SYS_FREEBSD */ >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: >Unformatted: