From owner-freebsd-net@freebsd.org  Sat Jan 16 03:26:37 2016
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5DBE6A84246;
 Sat, 16 Jan 2016 03:26:37 +0000 (UTC)
 (envelope-from white_knight@2ch.net)
Received: from mail.nttec.com (mail.nttec.com [207.29.234.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4AB6C1CD5;
 Sat, 16 Jan 2016 03:26:36 +0000 (UTC)
 (envelope-from white_knight@2ch.net)
Received: from mail.nttec.com (localhost [127.0.0.1])
 by mail.nttec.com (Postfix) with ESMTPA id 547FF1410F5;
 Fri, 15 Jan 2016 19:18:44 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Sat, 16 Jan 2016 11:18:44 +0800
From: White Knight <white_knight@2ch.net>
To: Adrian Chadd <adrian.chadd@gmail.com>
Cc: FreeBSD Net <freebsd-net@freebsd.org>, owner-freebsd-net@freebsd.org
Subject: Re: Getting a review for kern.ipc.acceptqueue [203922]?
Organization: 2ch.net
In-Reply-To: <CAJ-Vmon-eqZNhT1m59GkR+kgF-foJ_biWtBydyjyR39FoMgFkg@mail.gmail.com>
References: <01b582ed60781189765118c67c0c9160@2ch.net>
 <CAJ-Vmon-eqZNhT1m59GkR+kgF-foJ_biWtBydyjyR39FoMgFkg@mail.gmail.com>
Message-ID: <c5b3384544ec9c10f7c31f997d6dbd01@2ch.net>
X-Sender: white_knight@2ch.net
User-Agent: Roundcube Webmail/1.1.3
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Jan 2016 03:26:37 -0000

Hi,

On 2016-01-16 10:57, Adrian Chadd wrote:

> So the main comment from me is "you didn't do enough to add your
> copyright to the file", but other than that it looks sane.However, I
> wonder if it changes the layout of anything that we have to care
> about.

Are you talking about the userland ABI, or the text formatting in
netstat or both?

  - wk

> On 15 January 2016 at 18:14, White Knight <white_knight@2ch.net> wrote:
>> Hi all,
>> 
>> Can I get some reviews or comments on my kern.ipc.acceptqueue patch? 
>> At
>> 
>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203922

-- 
White Knight

I'm not from 2ch.net, I just work there.