From nobody Wed Jan 18 15:56:23 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Nxr3H6Cnzz2yF2s; Wed, 18 Jan 2023 15:56:27 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Nxr3H40Gpz4c9J; Wed, 18 Jan 2023 15:56:27 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4003a.ext.cloudfilter.net ([10.228.9.183]) by cmsmtp with ESMTP id HzdOpGLK0l2xSIAnapRKRh; Wed, 18 Jan 2023 15:56:26 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id IAnYpqgQKcyvuIAnZpyKIg; Wed, 18 Jan 2023 15:56:26 +0000 X-Authority-Analysis: v=2.4 cv=VbHkgXl9 c=1 sm=1 tr=0 ts=63c816aa a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=RvmDmJFTN0MA:10 a=iKhvJSA4AAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=iQT5K8H0XoTOApLSRvMA:9 a=CjuIK1q_8ugA:10 a=odh9cflL3HIXMm4fY7Wr:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 5763311C0; Wed, 18 Jan 2023 07:56:24 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id F3FFD298; Wed, 18 Jan 2023 07:56:23 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: rgrimes@freebsd.org cc: Juraj Lutter , Cy Schubert , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 1d577bedbae8 - main - unbound: Fix config file path In-reply-to: <202301181551.30IFpbRu010474@gndrsh.dnsmgr.net> References: <202301181551.30IFpbRu010474@gndrsh.dnsmgr.net> Comments: In-reply-to "Rodney W. Grimes" message dated "Wed, 18 Jan 2023 07:51:37 -0800." List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 18 Jan 2023 07:56:23 -0800 Message-Id: <20230118155623.F3FFD298@slippy.cwsent.com> X-CMAE-Envelope: MS4xfJeV5qQNXQ5bez02nJAUiCRWtcDvLicmwgzwwdr86P0aCLKc+qlBS6dLn1NrzRxWBaxWNL/3urcfX41MDZ5+q8b5xCAsRoSovi+zQWqUZJJV0Num3jkC igEq43TN0oEQU6VAe7EUnXuHuhwIBOAA75itzUXwwqPYJafhbJgg6SXqEIoWi1JBwcxMly8+yYh20rlq6xO/rJGnO+Pbi9itgvKzrkWV87HFhL3PcJc0P1Lg E17n+vePto06YEvaHeKFAHnhY28j6SltFWCIAb14ZXSZgY+1522ZauiAMBy0xNa4PLAecdQmg/vkpR1Z8bRcpeQyoXdew5FYgWFw32nFKd9XgNMIAUT1mMx4 2xD5iDVJ X-Rspamd-Queue-Id: 4Nxr3H40Gpz4c9J X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N In message <202301181551.30IFpbRu010474@gndrsh.dnsmgr.net>, "Rodney W. Grimes" writes: > [ Charset UTF-8 unsupported, converting... ] > > > > > > > On 18 Jan 2023, at 16:34, Rodney W. Grimes wr > ote: > > > > > > No, otis fixed it thus: > > > -#define CONFIGFILE "/usr/local/etc/unbound/unbound.conf" > > > +#define CONFIGFILE "/var/unbound/unbound.conf" > > > > > > > > > > I am suggesting that it should be > > > #define CONFIGFILE "/etc/unbound/unbound.conf" > > > > > > ALL base system configuration files *should* be relative to /etc, not /va > r. > > > > > > > Would this need any mtree changes or similar? > > No, /etc/unbound is a symbolic link already installed by the build system, > and /var/unbound is already a directory, again, installed by the build system > . > > This is a one line change that actually makes the /etc/unbound link work > correctly, without this change the binary has a hard coded path that ignores > the > /etc/unbound symbolic link and requires a recompile if I want to move > things around, or maintanance of 2 symbolic links. > > Personally I dont see *why* unbound has a /var/unbound directory, can > someone tell me why that was done? Is this some attempt and maintaining > read only root? Does unbound scribble in the config directory, or > is this simply mirroring some of the stuff that bind did? I don't know why it was done but it should be in /etc. I'll submit a review to change it. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0