From owner-freebsd-current@FreeBSD.ORG  Tue Jul  1 16:45:36 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B8EAA1065679;
	Tue,  1 Jul 2008 16:45:36 +0000 (UTC) (envelope-from vova@sw.ru)
Received: from relay.sw.ru (mailhub.sw.ru [195.214.232.25])
	by mx1.freebsd.org (Postfix) with ESMTP id 3BE638FC1F;
	Tue,  1 Jul 2008 16:45:35 +0000 (UTC) (envelope-from vova@sw.ru)
Received: from vbook.fbsd.ru ([10.30.1.111]) (authenticated bits=0)
	by relay.sw.ru (8.13.4/8.13.4) with ESMTP id m61GjVPE021427
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 1 Jul 2008 20:45:33 +0400 (MSD)
Received: from vova by vbook.fbsd.ru with local (Exim 4.69 (FreeBSD))
	(envelope-from <vova@sw.ru>)
	id 1KDiyw-000Mjb-VX; Tue, 01 Jul 2008 20:45:31 +0400
From: Vladimir Grebenschikov <vova@fbsd.ru>
To: Tim Kientzle <kientzle@freebsd.org>
In-Reply-To: <486A53AD.9090904@freebsd.org>
References: <20080626110521.GA68764@wep4017.physik.uni-wuerzburg.de>
	<1214815958.3581.67.camel@localhost>  <486901FB.5080308@freebsd.org>
	<1214842042.8768.12.camel@localhost>  <4869C4C4.1050806@freebsd.org>
	<1214900266.1947.13.camel@localhost>  <486A53AD.9090904@freebsd.org>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Organization: SWsoft
Date: Tue, 01 Jul 2008 20:45:30 +0400
Message-Id: <1214930730.1898.3.camel@localhost>
Mime-Version: 1.0
X-Mailer: Evolution 2.22.3.1 FreeBSD GNOME Team Port 
Sender: Vladimir Grebenschikov <vova@swsoft.com>
Cc: freebsd-current@freebsd.org
Subject: Re: cpio -dumpl damages the files?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: vova@fbsd.ru
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Jul 2008 16:45:36 -0000

On Tue, 2008-07-01 at 08:56 -0700, Tim Kientzle wrote:
> Vladimir Grebenschikov wrote:
> > On Mon, 2008-06-30 at 22:46 -0700, Tim Kientzle wrote:
> > 
> >>Vladimir Grebenschikov wrote:
> >>
> >>>
> >>>Files are not corrupted any more, but strange message for every
> >>>directory still shown.
> >>
> >>Yes.  I think I just fixed this.  Please let me know if
> >>you see any other problems.
> > 
> > Now it works ok with directories, but I think, condition is too generic:
> > 
> > +       if (cpio->option_link
> > +           && archive_entry_filetype(entry) != AE_IFDIR)
> > +       {
> 
> [ ... example showing breakage copying symlinks ... ]
> 
> Try adding the following to the above condition:
> 
>      && archive_entry_filetype(entry) != AE_IFLNK

I guess it will work. I just wander about other AE_IF* that may not pass
link(2).

-- 
Vladimir B. Grebenschikov
vova@fbsd.ru