From owner-freebsd-current  Wed Aug 30  7:55:33 2000
Delivered-To: freebsd-current@freebsd.org
Received: from lists01.iafrica.com (lists01.iafrica.com [196.7.0.141])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4729E37B42C; Wed, 30 Aug 2000 07:55:27 -0700 (PDT)
Received: from nwl.fw.uunet.co.za ([196.31.2.162])
	by lists01.iafrica.com with esmtp (Exim 3.12 #2)
	id 13U9Gu-0001al-00; Wed, 30 Aug 2000 16:55:24 +0200
Received: (from nobody@localhost) by nwl.fw.uunet.co.za (8.8.8/8.6.9) id QAA27178; Wed, 30 Aug 2000 16:55:22 +0200 (SAST)
Received: by nwl.fw.uunet.co.za via recvmail id 27043; Wed Aug 30 16:54:51 2000
Received: from sheldonh (helo=axl.fw.uunet.co.za)
	by axl.fw.uunet.co.za with local-esmtp (Exim 3.16 #1)
	id 13U9GN-000HbR-00; Wed, 30 Aug 2000 16:54:51 +0200
From: Sheldon Hearn <sheldonh@uunet.co.za>
To: phk@freebsd.org
Cc: current@freebsd.org
Subject: recent change to conf.h breaks xosview port
Date: Wed, 30 Aug 2000 16:54:51 +0200
Message-ID: <67668.967647291@axl.fw.uunet.co.za>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG


Hi Poul-Henning,

As of rev 1.116 of sys/sys/conf.h, the xosview port no longer builds.
Your delta added 3 struct timespec members to struct specinfo.

The affected xosview file includes the following headers files in
order:

#include <sys/param.h>
#include <sys/conf.h>

[...]

The breakage looks like this:

In file included from swapinternal.cc:67:
/usr/include/sys/conf.h:59: field `si_atime' has incomplete type
/usr/include/sys/conf.h:60: field `si_ctime' has incomplete type
/usr/include/sys/conf.h:61: field `si_mtime' has incomplete type

Including <sys/time.h> between the inclusion of <sys/param.h> and
<sys/conf.h> corrects the problem.

Was this use of <sys/conf.h> always broken and only now problematic, or
is there a new problem in <sys/conf.h>?

To me, it looks like <sys/conf.h> should pull <sys/time.h> in for
itself, although I understand that pollution comes along with that.

Ciao,
Sheldo.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message