From owner-svn-src-head@freebsd.org Tue Apr 25 20:28:36 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 274E0D50F2C; Tue, 25 Apr 2017 20:28:36 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F1FEEBB5; Tue, 25 Apr 2017 20:28:35 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id B745B10A7B9; Tue, 25 Apr 2017 16:28:27 -0400 (EDT) From: John Baldwin To: rgrimes@freebsd.org Cc: Benjamin Kaduk , Gleb Smirnoff , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Subject: Re: svn commit: r317409 - head/contrib/tcpdump Date: Tue, 25 Apr 2017 13:28:19 -0700 Message-ID: <9709200.gDHZIeQ1vL@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-STABLE; KDE/4.14.10; amd64; ; ) In-Reply-To: <201704252010.v3PKA0ba063109@pdx.rh.CN85.dnsmgr.net> References: <201704252010.v3PKA0ba063109@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Tue, 25 Apr 2017 16:28:27 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 20:28:36 -0000 On Tuesday, April 25, 2017 01:10:00 PM Rodney W. Grimes wrote: > > full > > (github or otherwise) URL including the commit hash to just a bare commit > > hash, > > but find either acceptable and adequate for the purpose. (FWIW, the > > correct commit > > was the top google hit for me.) > > > > I hope we are in agreement that commit messages ought to still include some > > description of what change is being brought in, in addition to the > > hash/link, though. > > Commit messages should stand complete and alone, without need to refernce > outside material to understand what was changed and why it was changed. > Again, at best Obtained From: should of been a usable url. I think this is perhaps the point of contention, and I think while the sentiment is correct, I would not apply it to this commit. The commit message should indeed describe what is going on, but having a citation inline vs in the footnotes isn't invalid in and of itself. (FWIW, Obtained From generally references another project rather than a single commit, so 'Obtained From: FooBSD', or 'Obtained from: tcpdump') We also make several references to other source code revisions in outside repositories in commits. Just look at commits to makefs that refer to CVS revisions when merging changes from NetBSD, or any of the changes to ZFS that always reference the revision identifier from illumos. I do think that when referring to a Git hash the citation should also include something to identify which repository it came from. It doesn't have to be a URL per se (we just use 'NetBSD' for makefs, not a full URL to NetBSD's cvsweb), but it should be clear enough that one can find the corresponding repository. Probably that information belongs in 'Obtained From'. -- John Baldwin