From owner-freebsd-stable@FreeBSD.ORG Sun Jan 13 18:12:04 2013 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id B20ED41B; Sun, 13 Jan 2013 18:12:04 +0000 (UTC) (envelope-from markiyan.kushnir@gmail.com) Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by mx1.freebsd.org (Postfix) with ESMTP id 07276242; Sun, 13 Jan 2013 18:12:03 +0000 (UTC) Received: by mail-wi0-f182.google.com with SMTP id hn14so818035wib.9 for ; Sun, 13 Jan 2013 10:11:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=AaNoFPQfKzUj5HpBH7mNx9KqzZWju5qAwJBJN9suKzU=; b=vvVqu7YIiZDxHMzXq02XXJwja/wOOHkdhFfts0iol7yrb/e+8eHTXUiFKx+3Jww7wC iEjpir5hlplyPN1szQdVJgxUJIN+hIrRaX9jyNh5trtJBzR2jaXmWe4TdPUgAQAgbd8F J2A1TK/je5CljtWewBV24li+7A1mKEnqkjiCIeVTfeln8GBmpaCsESi6S3hJQnUw8YJe Fr4392PZ5Cm3f+tfJdnfWNccrWnWz+QwGOiMGpaLyxwHZvlv/c1sALpc8tr+p/SlnIRw 0U8DBbuNyp1ftd2LEiXrTLR0imlX/Xvns6ZFcqrzcd6u/Yj0mj1cFb3uY3SNGqotcVlF 0FgQ== X-Received: by 10.180.84.131 with SMTP id z3mr8480986wiy.25.1358100716832; Sun, 13 Jan 2013 10:11:56 -0800 (PST) Received: from mkushnir.zapto.org (170-113-132-95.pool.ukrtel.net. [95.132.113.170]) by mx.google.com with ESMTPS id w5sm9191424wif.11.2013.01.13.10.11.55 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 13 Jan 2013 10:11:56 -0800 (PST) Message-ID: <50F2F8B1.5010702@gmail.com> Date: Sun, 13 Jan 2013 20:10:57 +0200 From: Markiyan Kushnir User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:16.0) Gecko/20121119 Thunderbird/16.0.2 MIME-Version: 1.0 To: Juergen Lock Subject: Re: VIDIOC_ENUM_FRAMESIZES in linux_ioctl.c References: <50F2DCA1.8080208@gmail.com> <20130113164838.GA73810@triton8.kn-bremen.de> In-Reply-To: <20130113164838.GA73810@triton8.kn-bremen.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Cc: nox@freebsd.org, stable@freebsd.org, netchild@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jan 2013 18:12:04 -0000 On 13.01.2013 18:48, Juergen Lock wrote: > On Sun, Jan 13, 2013 at 06:11:13PM +0200, Markiyan Kushnir wrote: >> Hi, >> >> Any reason why LINUX_VIDIOC_ENUM_FRAMESIZES, >> LINUX_VIDIOC_ENUM_FRAMEINTERVALS, LINUX_VIDIOC_ENCODER_CMD, and >> LINUX_VIDIOC_TRY_ENCODER_CMD in compat/linux/linux_ioctl.c have been p= ut >> under #ifdef VIDIOC_ENUM_FRAMESIZES (looks like it's been there since >> rev. 221426, when the v4l2 support was introduced) ? >> >> I've just hit an issue with the current Skypes in the ports tree (both= >> 2.1.0.81 and 2.2.0.35) trying to call at least the >> LINUX_VIDIOC_ENUM_FRAMESIZES ioctl, so I re-built linux.ko with >> -DVIDIOC_ENUM_FRAMESIZES and found no visible issues on my desktop so >> far beyond that my skype started to send video. >> >> If there is some reason, it would be good to let people know why these= >> ioctls are turned off by default. >> > IIRC netchild's concern was that these were not in Linux 2.6.16 that > our Linuxolator defaults to emulating, so I put them under #ifdef. > Did you find that skype video doesn't work without them? Back when > I tested it it didn't seem to make a difference... (Tho I never > could get skype 2.2.0.35 to work with video, I think because it > tries to use inotify() which we don't emulate.) > ok, I see now. On my desktop, when trying to test skype video, I had=20 been getting: Jan 13 15:54:40 mkushnir kernel: linux: pid 48266 (skype): ioctl fd=3D44,= =20 cmd=3D0x564a ('V',74) is not implemented I was confused by that pwcview worked for me, but skype didn't. I found=20 that 0x564a is in that bunch of those under #ifdef ... I then recompiled the linux module with VIDIOC_ENUM_FRAMESIZES defined,=20 and skype started to send video. Yes, skype still tries to call=20 inotify_init() at startup, and one of its child processes dies desperatel= y: Jan 13 20:01:58 mkushnir kernel: linux: pid 84673 (skype): ioctl fd=3D26,= =20 cmd=3D0x8b01 ('=EF=BF=BD',1) is not implemented Jan 13 20:01:58 mkushnir last message repeated 9 times Jan 13 20:01:58 mkushnir kernel: linux: pid 84673 (skype): ioctl fd=3D27,= =20 cmd=3D0x8b01 ('=EF=BF=BD',1) is not implemented Jan 13 20:01:58 mkushnir last message repeated 9 times Jan 13 20:01:58 mkushnir kernel: linux: pid 84682 (skype): syscall=20 inotify_init not implemented Jan 13 20:01:59 mkushnir kernel: Failed to write core file for process=20 skype (error 14) Jan 13 20:01:59 mkushnir kernel: pid 84681 (skype), uid 1001: exited on=20 signal 6 but then video test passes OK, and I can actually send/receive video in=20 a session. I don't know if this breaks other things, so the ioctls probably should=20 be kept closed. -- Markiyan. > HTH, > Juergen >