From owner-cvs-gnu Mon Nov 11 12:31:37 1996 Return-Path: owner-cvs-gnu Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id MAA07758 for cvs-gnu-outgoing; Mon, 11 Nov 1996 12:31:37 -0800 (PST) Received: from dyson.iquest.net ([198.70.144.127]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id MAA07749; Mon, 11 Nov 1996 12:31:32 -0800 (PST) Received: (from root@localhost) by dyson.iquest.net (8.8.2/8.6.9) id PAA03109; Mon, 11 Nov 1996 15:31:14 -0500 (EST) From: John Dyson Message-Id: <199611112031.PAA03109@dyson.iquest.net> Subject: Re: cvs commit: src/gnu/usr.bin/as/opcode i386.h To: ache@nagual.ru (=?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?=) Date: Mon, 11 Nov 1996 15:31:13 -0500 (EST) Cc: dyson@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-gnu@freefall.freebsd.org In-Reply-To: <199611111943.WAA00385@nagual.ru> from "=?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?=" at Nov 11, 96 10:43:31 pm Reply-To: dyson@freebsd.org X-Mailer: ELM [version 2.4 PL24 ME8] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-gnu@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > > dyson 96/11/11 11:03:53 > > > > Modified: gnu/usr.bin/as/opcode i386.h > > Log: > > Add the PPro %cr4 register to the supported registers in the > > assembler. > > > > Revision Changes Path > > 1.5 +2 -1 src/gnu/usr.bin/as/opcode/i386.h > > > > Maybe locore.s code need to be #ifdefed for CPUs >= PPro? > I guess it would be minimally useful -- the system will not attempt to execute the instructions if not PPro though. (We are only talking several longwords of overhead, executed only once.) The pmap code is probably a better candidate, because the code is executed many times. I generally find #ifdef pollution to obscure code. But if it seems that we are worried about the few bytes, then I guess I wouldn't be that opposed to the #ifdefs. John