Date: Mon, 01 Nov 2004 13:59:20 +0100 From: Sebastian Schulze Struchtrup <seb@struchtrup.com> To: FreeBSD-gnats-submit@freebsd.org Cc: acpi@freebsd.org Subject: [patch] kldload acpi_asus.ko causes page fault on Samsung P35 Message-ID: <E1CObmK-000D37-02@notebook.intranet.struchtrup.com>
next in thread | raw e-mail | index | archive | help
>Submitter-Id: current-users >Originator: Sebastian Schulze Struchtrup >Confidential: no >Synopsis: [patch] kldload acpi_asus.ko causes page fault on Samsung P35 >Severity: non-critical >Priority: medium >Category: i386 >Class: sw-bug >Release: FreeBSD 5.3-RC2 i386 >Environment: System: FreeBSD notebook.intranet.struchtrup.com 5.3-RC2 FreeBSD 5.3-RC2 #6: Sun Oct 31 19:22:38 CET 2004 seb@notebook.intranet.struchtrup.com:/usr/obj/usr/src/sys/notebook i386 >Description: The Samsung P30/P35 notebooks have an Asus ATK device. But on ATK Init, they return a null pointer instead of a model identification. This results in a page fault in acpi_asus_probe (strcmp againt null pointer) The linux acpi4asus identifies them by an "ODEM" string as their DSDT Oem Table ID. >Fix: I have modified the acpi_asus_probe function to identify the notebook via the "ODEM" string. We have to see if this will work in the future or if there are other notebooks with the same string which require different handling. At least the linux acpi4asus seems to work without problems with this approach. Addionally, I have splitted the acpi_asus_models struct and added an extra struct acpi_asus_extra_models. The first contains the models which are identified by their model identification (inside the for loop), the second one contains models identified in another way (currently, only the Samsung P30/35). The enum acpi_asus_extra_models_idx holds their indices. I have also introduced a longname attribute in both tables, which contains the full name including Manufacturer. This is only used for correctly setting/printing driver information. Switching WLAN on/off and reporting events to devd with various special keys and Fn-key combinations works fine. This patch should not break anything, but I was not able to test it with a real Asus notebook. Someone should do this before committing
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E1CObmK-000D37-02>