From nobody Fri Aug 25 22:55:19 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RXZzX4TRHz4qvbw; Fri, 25 Aug 2023 22:55:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RXZzX1TsVz4Hf5; Fri, 25 Aug 2023 22:55:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693004120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vjDrosolCL7gtfiqoCeISi1FyMkfzLXwpW/GX4cg4ec=; b=OcOirwbrCwNHSS0QxUtQY31trqf9Y+5uRqhcX32N95f8KSbYdIXP9eJ7i/YZKMTsP/q1Sr pSkTXNa0Ci9Ew3tFB/n0fpuZnZArT3Vp7/E0JPR6jRtFWU6xHjW/QYEbBGVDfT/B90oXCK mNCePrDMWRSwWUppaH3UM6k5R4QIo0JKOT0WKkeFS+JK5z26zYZpONNU9usNRkro3vpYiS 8a7O4PfZBH4IyZkAIQY/79aWnAzqNjN2iD3oaZFzuOpb+/Bc+AQo91DEcN0V9hFrK8BaYZ eDui4GPgEuiTUYIB1Fz4SzfnAl/ZJG5Ozwgfy0H0TGQ2mgv75TW6B5BT7/M8VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693004120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vjDrosolCL7gtfiqoCeISi1FyMkfzLXwpW/GX4cg4ec=; b=p0qoS2Jjqxo8L/mmtfL5oJXpEIJGFZH7H6r7ffA5vtLSHI+2TrDCjnUz1BGsHgVafFSWs5 ztizjjBRaxsEN/5b/SaM87cvN6ndF3fzrJ4x9Btwzfo0jtY3V2bWn2W5vfP1ss27okSLL2 uwXtn/czXyT2V0+mDkiyNPSXMBsRcYKmwTVPmbCLyKegRib7HvcaNNR2/HFpK7ofVwdHBs HuCcauFOD9u0iekuNiMMCXSaGIphCabCzUWQ4w0pqG3MOJ4xyw/MN0p8VWJS/PM/+Keb6G R2UL3lijMF5Eny6GPJAemoax68wHLX5KV4ttPQUA2FUfYxpZiBDlTSpbsdIqdA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1693004120; a=rsa-sha256; cv=none; b=xnLtqaK3C0nXOZIvJZShhwiQ9nnrvlWj1czGByrpGJSh/mIVhy9GAX2VFcq1qR4Jr9i4SY n8shlLeAfMdpZYT+/JUZ5/TypH/BlRdLv9rThePp0AFpgikmyzMJdSBX44yvmnvE6x/9Du Siz3cCMt02/tCu5Ik2Jj0RaUC3sLDk+M0abKSkUUquP1aSvMi0DyAN3x2aJNCI+15mug3O n3vmdaUho00oD+mBOyhydZ9U5zYj3410wibbAPzTU7EfDEAJ4OzPQbKVIGZHnvb1v4Amdn Ak8KpEkzs1To0L8WlxF2Dd8skt6xD0O759OHeeRK9uEdo/RXJ7XvKELScxBXqQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RXZzX0b37z1Q0v; Fri, 25 Aug 2023 22:55:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 37PMtJst031727; Fri, 25 Aug 2023 22:55:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 37PMtJtN031724; Fri, 25 Aug 2023 22:55:19 GMT (envelope-from git) Date: Fri, 25 Aug 2023 22:55:19 GMT Message-Id: <202308252255.37PMtJtN031724@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mateusz Guzik Subject: git: 84e1b8b965c2 - stable/13 - vfs: flip deferred_inact to atomic List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 84e1b8b965c28e4ea68d033c3c6b3f397d47cf1f Auto-Submitted: auto-generated The branch stable/13 has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=84e1b8b965c28e4ea68d033c3c6b3f397d47cf1f commit 84e1b8b965c28e4ea68d033c3c6b3f397d47cf1f Author: Mateusz Guzik AuthorDate: 2023-03-25 13:31:17 +0000 Commit: Mateusz Guzik CommitDate: 2023-08-25 22:52:50 +0000 vfs: flip deferred_inact to atomic Turns out it is very rarely triggered, making a per-cpu counter a waste. Examples from real life boxes: uptime counter 135 days 847 138 days 2190 141 days 1 (cherry picked from commit 245767c2782ef2e29340be0a6755be817f16bad4) --- sys/kern/vfs_subr.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index 6befc5eead0e..57e619abaa15 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -195,9 +195,9 @@ static counter_u64_t recycles_free_count; SYSCTL_COUNTER_U64(_vfs, OID_AUTO, recycles_free, CTLFLAG_RD, &recycles_free_count, "Number of free vnodes recycled to meet vnode cache targets"); -static counter_u64_t deferred_inact; -SYSCTL_COUNTER_U64(_vfs, OID_AUTO, deferred_inact, CTLFLAG_RD, &deferred_inact, - "Number of times inactive processing was deferred"); +static u_long deferred_inact; +SYSCTL_ULONG(_vfs, OID_AUTO, deferred_inact, CTLFLAG_RD, + &deferred_inact, 0, "Number of times inactive processing was deferred"); /* To keep more than one thread at a time from running vfs_getnewfsid */ static struct mtx mntid_mtx; @@ -724,7 +724,6 @@ vntblinit(void *dummy __unused) vnodes_created = counter_u64_alloc(M_WAITOK); recycles_count = counter_u64_alloc(M_WAITOK); recycles_free_count = counter_u64_alloc(M_WAITOK); - deferred_inact = counter_u64_alloc(M_WAITOK); /* * Initialize the filesystem syncer. @@ -3218,7 +3217,7 @@ vdefer_inactive(struct vnode *vp) vlazy(vp); vp->v_iflag |= VI_DEFINACT; VI_UNLOCK(vp); - counter_u64_add(deferred_inact, 1); + atomic_add_long(&deferred_inact, 1); } static void