From owner-freebsd-audit Mon Jul 15 8: 6:34 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 15DAB37B400; Mon, 15 Jul 2002 08:06:33 -0700 (PDT) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2898C43E64; Mon, 15 Jul 2002 08:06:30 -0700 (PDT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.3/8.12.3) with ESMTP id g6FF6I1f007140; Mon, 15 Jul 2002 09:06:18 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 15 Jul 2002 09:05:42 -0600 (MDT) Message-Id: <20020715.090542.07693309.imp@bsdimp.com> To: keramida@FreeBSD.ORG Cc: des@ofug.org, bde@zeta.org.au, freebsd-audit@FreeBSD.ORG Subject: Re: bin/ln & WARNS=5 From: "M. Warner Losh" In-Reply-To: <20020715114437.GA51994@hades.hell.gr> References: <20020715112116.GE50130@hades.hell.gr> <20020715114437.GA51994@hades.hell.gr> X-Mailer: Mew version 2.1 on Emacs 21.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <20020715114437.GA51994@hades.hell.gr> Giorgos Keramidas writes: : On 2002-07-15 13:37 +0000, Dag-Erling Smorgrav wrote: : > Giorgos Keramidas writes: : > > What's wrong with sizeof(...)? I thought that style(9) was actually : > > encouraging the use of parentheses for the arguments of sizeof, when : > > it mentioned: : > > : > > Casts and sizeof's are not followed by a space. Note that : > > indent(1) does not understand this rule. : > : > There are two different cases - one is "sizeof(type)" which requires : > parentheses, the other is "sizeof variable" which doesn't. In the : > latter case, the rule about avoiding unnecessary parentheses applies. That's not always the case. sizeof type always works too. The convention is that sizeof(foo) is done in BSD sources. : Ah ! [ enlightenment ] : : That would require a major style sweep in ln.c though. Such changes : should be done in a separate commit, right? Yes, they are done with a separate commit, but not when it is the wrong thing to do. Leave sizeof(var) alone please. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message