From owner-svn-src-all@freebsd.org Fri Jan 22 19:22:14 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D6527A8E3F6 for ; Fri, 22 Jan 2016 19:22:14 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from erouter6.ore.mailhop.org (erouter6.ore.mailhop.org [54.187.213.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B96241E72 for ; Fri, 22 Jan 2016 19:22:14 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from ilsoft.org (unknown [73.34.117.227]) by outbound3.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Fri, 22 Jan 2016 19:20:24 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.14.9) with ESMTP id u0MJM6Ct018857; Fri, 22 Jan 2016 12:22:06 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1453490526.46848.108.camel@freebsd.org> Subject: Re: svn commit: r294562 - head/sys/dev/fdt From: Ian Lepore To: Adrian Chadd , Andrew Turner Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Date: Fri, 22 Jan 2016 12:22:06 -0700 In-Reply-To: References: <201601221309.u0MD9hmn069967@repo.freebsd.org> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jan 2016 19:22:14 -0000 On Fri, 2016-01-22 at 10:26 -0800, Adrian Chadd wrote: > ... we're about to start using FDT on MIPS, so .. ? > > > -a > But mips will be using intrng from the outset, only the arm platforms that don't yet use intrng need fdt_pic_table. -- Ian > > On 22 January 2016 at 05:09, Andrew Turner > wrote: > > Author: andrew > > Date: Fri Jan 22 13:09:43 2016 > > New Revision: 294562 > > URL: https://svnweb.freebsd.org/changeset/base/294562 > > > > Log: > > Only define fdt_pic_table on arm, and when not using intrng as > > this is > > the only place that uses it. > > > > Modified: > > head/sys/dev/fdt/fdt_common.h > > > > Modified: head/sys/dev/fdt/fdt_common.h > > =================================================================== > > =========== > > --- head/sys/dev/fdt/fdt_common.h Fri Jan 22 12:51:12 2016 > > (r294561) > > +++ head/sys/dev/fdt/fdt_common.h Fri Jan 22 13:09:43 2016 > > (r294562) > > @@ -45,8 +45,10 @@ struct fdt_sense_level { > > enum intr_polarity pol; > > }; > > > > +#if defined(__arm__) && !defined(ARM_INTRNG) > > typedef int (*fdt_pic_decode_t)(phandle_t, pcell_t *, int *, int > > *, int *); > > extern fdt_pic_decode_t fdt_pic_table[]; > > +#endif > > > > #if defined(__arm__) || defined(__powerpc__) > > typedef void (*fdt_fixup_t)(phandle_t); > > >