From owner-p4-projects@FreeBSD.ORG  Mon Feb  6 19:17:30 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 7414816A423; Mon,  6 Feb 2006 19:17:29 +0000 (GMT)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 0C4E716A422;
	Mon,  6 Feb 2006 19:17:29 +0000 (GMT) (envelope-from jhb@freebsd.org)
Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 382CB43D45;
	Mon,  6 Feb 2006 19:17:28 +0000 (GMT) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (unverified [66.23.211.162]) 
	by speedfactory.net (SurgeMail 3.5b3) with ESMTP id 7868658 
	for multiple; Mon, 06 Feb 2006 14:18:12 -0500
Received: from localhost (john@localhost [127.0.0.1])
	by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k16JHR8n041914;
	Mon, 6 Feb 2006 14:17:27 -0500 (EST) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Warner Losh <imp@freebsd.org>
Date: Mon, 6 Feb 2006 13:48:50 -0500
User-Agent: KMail/1.9.1
References: <200602040903.k1493lFu093402@repoman.freebsd.org>
In-Reply-To: <200602040903.k1493lFu093402@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200602061348.51792.jhb@freebsd.org>
X-Virus-Scanned: ClamAV 0.87.1/1278/Mon Feb 6 06:05:04 2006 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-1.4 required=4.2 tests=ALL_TRUSTED autolearn=failed 
	version=3.1.0
X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx
X-Server: High Performance Mail Server - http://surgemail.com r=1653887525
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 91042 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Feb 2006 19:17:30 -0000

On Saturday 04 February 2006 04:03, Warner Losh wrote:
> http://perforce.freebsd.org/chv.cgi?CH=91042
>
> Change 91042 by imp@imp_plunger on 2006/02/04 09:02:46
>
> 	Fix spelling error
> 	Move locking to avoid nesting the locking and to give the locking a
> 	smaller scope.

You shouldn't have a LOR with the IF_ADDR_LOCK unless you have some LOR 
somewhere else.  I used a rather simple version of locking for nic drivers 
where the lock was basically held for all of foo_start(), foo_init(), the 
ISR, etc.

-- 
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org