From owner-freebsd-bugs@freebsd.org Sat May 7 20:22:03 2016 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E98EEB32C9D for ; Sat, 7 May 2016 20:22:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C03FB170E for ; Sat, 7 May 2016 20:22:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u47KM3jN045538 for ; Sat, 7 May 2016 20:22:03 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 209368] [PATCH] bsnmpd: snmp_hostres: Only refresh devtree if devd event is a new or removed device Date: Sat, 07 May 2016 20:22:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 10.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: marcus@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter cc attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 May 2016 20:22:04 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209368 Bug ID: 209368 Summary: [PATCH] bsnmpd: snmp_hostres: Only refresh devtree if devd event is a new or removed device Product: Base System Version: 10.0-STABLE Hardware: amd64 OS: Any Status: New Keywords: patch Severity: Affects Some People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: marcus@FreeBSD.org CC: freebsd-amd64@FreeBSD.org CC: freebsd-amd64@FreeBSD.org Keywords: patch Created attachment 170101 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D170101&action= =3Dedit Only refresh device table on a device add or remove event In a recent update of 10-STABLE, devd began spewing: !system=3DCAM subsystem=3Dperiph type=3Derror device=3Dcd0 serial=3D"10000000000000000001" cam_status=3D"0xcc" scsi_status=3D2 scsi_se= nse=3D"70 02 3a 00" CDB=3D"00 00 00 00 00 00 "=20 This caused bsnmpd to take up nearly 100% of the CPU refreshing the devtree table every second. Admittedly, this is an issue in the CAM driver, but why refresh the whole tree each time a device is not either inserted or removed? The attached patch corrects this by only refreshing the devtree when a devi= ce is added or removed. --=20 You are receiving this mail because: You are the assignee for the bug.=