From owner-svn-src-all@FreeBSD.ORG Mon Mar 19 07:21:41 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 007B0106566B; Mon, 19 Mar 2012 07:21:41 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id EFE1B8FC12; Mon, 19 Mar 2012 07:21:39 +0000 (UTC) Received: by bkcjc3 with SMTP id jc3so5643541bkc.13 for ; Mon, 19 Mar 2012 00:21:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=6Egw8MFzlyaSFqXg2sTA9twQfSATr7jyPZi1asxeu28=; b=zNWlU3J4hxS9zZnX1KiVwWvH/kTTr3wtuVGmqvKf2D+GvtQp9Qpmu/jTRg4suh6B9l OmyGxG3v2tl7QYpYXnSwSHQdey9m/xDcEfWIkVIdHcsB/xpx77VRoox3rR3loEbC8y2b IxZW68HmpFW+FzbdKovAIrXGQ9gvIWS5g8g6j3PvOMHRdhQjFJRWsp4mGyjNwA19nbhX bsM7XSraVWCjPjWllqhifaJ/CYniA+2ZW7Kreo7iVqmqsxF8gK7kY6w50IOsBRsClYUG 5AWJ0EaJajo0hoCbyyg41l5JxI+k+Ae+JuWtcOKUZpdL3aGP5dlMLaA7yYY8Q03ToLLH wbPg== MIME-Version: 1.0 Received: by 10.205.137.15 with SMTP id im15mr4204060bkc.54.1332141698806; Mon, 19 Mar 2012 00:21:38 -0700 (PDT) Received: by 10.204.202.142 with HTTP; Mon, 19 Mar 2012 00:21:38 -0700 (PDT) Received: by 10.204.202.142 with HTTP; Mon, 19 Mar 2012 00:21:38 -0700 (PDT) In-Reply-To: <20120317162754.I1530@besplex.bde.org> References: <201203162319.q2GNJjx5039482@svn.freebsd.org> <20120317162754.I1530@besplex.bde.org> Date: Mon, 19 Mar 2012 07:21:38 +0000 Message-ID: From: Chris Rees To: Bruce Evans Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Dimitry Andric Subject: Re: svn commit: r233052 - head/share/mk X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Mar 2012 07:21:41 -0000 On 17 Mar 2012 05:40, "Bruce Evans" wrote: > > On Fri, 16 Mar 2012, Dimitry Andric wrote: > >> Log: >> Change the style of share/mk/bsd.sys.mk to that of the other bsd.*.mk >> files, and style.Makefile(5), where applicable. While here, update the >> link to the gcc warning documentation. > > > Thanks. I rather liked the "^.* foo" style for making ifdefs less > unreadable, but it didn't look like it was written here, and it is > a sign of other problems that so many nested ifdefs are used. It > only used a single space of each level of indentation, so the > indentation was still hard too see. > > The "other bsd.*.mk" files don't include bsd.cpu.mk. This still uses > the "^. *foo" style (and is now the only *.mk file one that does this). > For assignments, it mostly uses a different unusual style -- just the > normal C style of a single space before and after '=' (or '+='). Weird > formattings of assignments are harder to grep for than weird formattings > of ".foo", so I didn't try looking for them all. > Indented .ifs etc are used (inconsistently) in bsd.port.mk et al, and can make a huge difference to readability; make is such a messy language that multiple levels are often needed. Perhaps we should try to agree a standard on them, perhaps two spaces? It's a shame to be stripping them out. Chris