From owner-freebsd-arm@FreeBSD.ORG  Fri Feb 13 22:01:20 2015
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 22ECFA8C
 for <freebsd-arm@freebsd.org>; Fri, 13 Feb 2015 22:01:20 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id F1A61E7
 for <freebsd-arm@freebsd.org>; Fri, 13 Feb 2015 22:01:19 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 t1DM1JZ3019903
 for <freebsd-arm@freebsd.org>; Fri, 13 Feb 2015 22:01:19 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1DM1Jh1019900;
 Fri, 13 Feb 2015 22:01:19 GMT (envelope-from root)
Date: Fri, 13 Feb 2015 22:01:19 +0000
To: freebsd-arm@freebsd.org
From: "rpaulo (Rui Paulo)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Requested Changes To] D1833: Add memory barriers to
 buf_ring
Message-ID: <727a18b80886ae40e11d76bde7fb26f4@localhost.localdomain>
X-Priority: 3
Thread-Topic: D1833: Add memory barriers to buf_ring
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-6m5mo2kjikkzyd33ld4n>
X-Phabricator-To: <PHID-USER-22avn2hssqzufmcg2crf>
X-Phabricator-To: <PHID-USER-q5lmute3rwskeizvu5gf>
X-Phabricator-To: <PHID-USER-k5bbpaejfd56ik2tjj37>
X-Phabricator-Cc: <PHID-USER-wmu3dipuua4kxljjqlii>
X-Phabricator-Cc: <PHID-MLST-stsrni3uozki6w7zubvy>
In-Reply-To: <differential-rev-PHID-DREV-ntnotl4wj5wcj2eoukly-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-ntnotl4wj5wcj2eoukly-req@FreeBSD.org>
Thread-Index: OGRiNDkxY2NmMjRiNTc0MjQ4YTYwNWVkNzIyIFTedC8=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-other>, <differential-reviewers>,
 <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "Porting FreeBSD to ARM processors." <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm/>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Feb 2015 22:01:20 -0000

rpaulo requested changes to this revision.
rpaulo added a comment.
This revision now requires changes to proceed.

Hmm, I think these memory barriers were in the tree but were removed recently.  I think it would be nice to use the atomic load acq/rel because this change could negatively impact x86.

REVISION DETAIL
  https://reviews.freebsd.org/D1833

To: zbb, kmacy, imp, rpaulo
Cc: adrian, freebsd-arm