From owner-cvs-all  Sun May  9 15: 9:49 1999
Delivered-To: cvs-all@freebsd.org
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.26.10.9])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7FC0314D95; Sun,  9 May 1999 15:09:43 -0700 (PDT)
	(envelope-from bde@godzilla.zeta.org.au)
Received: (from bde@localhost)
	by godzilla.zeta.org.au (8.8.7/8.8.7) id IAA24862;
	Mon, 10 May 1999 08:09:43 +1000
Date: Mon, 10 May 1999 08:09:43 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199905092209.IAA24862@godzilla.zeta.org.au>
To: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org,
	peter@FreeBSD.org
Subject: Re: cvs commit: src/sys/isa sio.c
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

>  Modified files:
>    sys/isa              sio.c 
>  Log:
>  Optimize out a couple of places where com_addr() is used twice in a row,
>  although this is pretty trivial.  devclass_get_softc() is a tad more
>  expensive than the old com_addr() implementation.  If Bruce is really
>  worried about the cost of this, it could always be changed so that the
>  softc pointer is stored in a local array again.

I'm not very worried about the cost.  I'm worried about the invalid
implementation.  It is invalid to access data not managed by the driver
from a fast interrupt handler.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message