From owner-freebsd-bugs@freebsd.org Fri Jul 17 00:29:23 2015 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 644549A3B59 for ; Fri, 17 Jul 2015 00:29:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 486F311EF for ; Fri, 17 Jul 2015 00:29:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t6H0TNsQ047996 for ; Fri, 17 Jul 2015 00:29:23 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 201641] /etc/rc.subr error fails to parse rc.conf.d directories from $local_startup correctly Date: Fri, 17 Jul 2015 00:29:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 10.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jamie@dyslexicfish.net X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2015 00:29:23 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201641 Bug ID: 201641 Summary: /etc/rc.subr error fails to parse rc.conf.d directories from $local_startup correctly Product: Base System Version: 10.2-STABLE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: conf Assignee: freebsd-bugs@FreeBSD.org Reporter: jamie@dyslexicfish.net /etc/rc.subr contains the following snippet: for _d in /etc ${local_startup%*/rc.d}; do if [ -f ${_d}/rc.conf.d/"$_name" ]; then debug "Sourcing ${_d}/rc.conf.d/$_name" . ${_d}/rc.conf.d/"$_name" However, as local_startup can contain more than one path, only the last entry has "/rc.d" stripped correctly, thus making the rc.conf.d directories invalid for other entries. This patch fixes it. Example, before patch: 0:02 (99) "/etc" root@lapcat# grep local_startup /etc/rc.conf local_startup="/usr/local/etc/rc.d /usr/common/etc/rc.d /usr/me/etc/rc.d" # startup script dirs. 23:48 (42) "/etc" root@lapcat# service lpd restart + [ -f /etc/rc.conf.d/XXX ] + [ -d /etc/rc.conf.d/XXX ] + [ -f /usr/local/etc/rc.d/rc.conf.d/XXX ] + [ -d /usr/local/etc/rc.d/rc.conf.d/XXX ] + [ -f /usr/common/etc/rc.d/rc.conf.d/XXX ] + [ -d /usr/common/etc/rc.d/rc.conf.d/XXX ] + [ -f /usr/me/etc/rc.conf.d/XXX ] + [ -d /usr/me/etc/rc.conf.d/XXX ] + [ -f /etc/rc.conf.d/lpd ] + [ -d /etc/rc.conf.d/lpd ] + [ -f /usr/local/etc/rc.d/rc.conf.d/lpd ] + [ -d /usr/local/etc/rc.d/rc.conf.d/lpd ] + [ -f /usr/common/etc/rc.d/rc.conf.d/lpd ] + [ -d /usr/common/etc/rc.d/rc.conf.d/lpd ] + [ -f /usr/me/etc/rc.conf.d/lpd ] + [ -d /usr/me/etc/rc.conf.d/lpd ] Example, after patch: 23:49 (43) "/etc" root@lapcat# service lpd restart + _d=/etc + [ -f /etc/rc.conf.d/XXX ] + [ -d /etc/rc.conf.d/XXX ] + _d=/usr/local/etc + [ -f /usr/local/etc/rc.conf.d/XXX ] + [ -d /usr/local/etc/rc.conf.d/XXX ] + _d=/usr/common/etc + [ -f /usr/common/etc/rc.conf.d/XXX ] + [ -d /usr/common/etc/rc.conf.d/XXX ] + _d=/usr/me/etc + [ -f /usr/me/etc/rc.conf.d/XXX ] + [ -d /usr/me/etc/rc.conf.d/XXX ] + _d=/etc + [ -f /etc/rc.conf.d/lpd ] + [ -d /etc/rc.conf.d/lpd ] + _d=/usr/local/etc + [ -f /usr/local/etc/rc.conf.d/lpd ] + [ -d /usr/local/etc/rc.conf.d/lpd ] + _d=/usr/common/etc + [ -f /usr/common/etc/rc.conf.d/lpd ] + [ -d /usr/common/etc/rc.conf.d/lpd ] + _d=/usr/me/etc + [ -f /usr/me/etc/rc.conf.d/lpd ] + [ -d /usr/me/etc/rc.conf.d/lpd ] This problem exists in 10-STABLE and 11-CURRENT As an aside, a commit to rc.subr by des 7 months ago, scheduled to be MFC after a week still hasn't bern actioned: base r275359 | des | Date: Mon Dec 1 12:17:42 2014 UTC (7 months, 2 weeks ago) | Log Message: Allow load_rc_config to be called without a service name. | | MFC after: 1 week Cheers, Jamie -- You are receiving this mail because: You are the assignee for the bug.