From owner-freebsd-current@freebsd.org Sat Aug 24 17:02:34 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7BC38C4C53 for ; Sat, 24 Aug 2019 17:02:34 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46G4MF4NTWz3QPj for ; Sat, 24 Aug 2019 17:02:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x835.google.com with SMTP id j15so14178847qtl.13 for ; Sat, 24 Aug 2019 10:02:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n5ceNiItwOElCLnjmiDapzD9cpDmj3tB4CA+SA3OnX0=; b=AF/TlPBJInrffLde4aKROhbqp0dv3tT0Fqvr3g9wYfVcBHhvVEwxIvFJj9WQTg7iJZ bQ/D+wGHcXHqHoy2hE3Ix9heluuCbu6E0QcVW80ei79N6aZ3RRVIZKelp28KDxJMMNxm 2OMtrilBKo00N1quN8SD97eyD8kK+weXNICkfwbc+b8kC1CH6UYmXjpSkQvKFHrHjG5c bnXWKrgUICqJQZ9LknYd7FohpmaGJyQK0wVOIi6T7WSZjEFsvDDO0CFO8G8cxaOVBD+H +9c7++JqKNy1u7+7+MosBn5ZCfSC+9bIsfnYKVYh+lAX6iaodVmj3oRagcLJ0Dt/Pe2V Fa/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n5ceNiItwOElCLnjmiDapzD9cpDmj3tB4CA+SA3OnX0=; b=FNjLhse1IvRDxLyjBJahaoZfxzqNQgw0sz48Z+SPtkfHHq31H9gDGSuwTpgtM8YDm+ gQy7AjZ9s4gtXNbZkRFC/u4VC8KX43m8g9SzwerTy9U2IVgokYQykvmLJMpdiWGR4Azi yJlx3nPgGsyjguNO/ykEUVeuPNeQ9wvVeVMK8o9XIpFJ0wsyncwUbpVqCORM1X72BdNq U2aQPxwkDEB9xhKfswg/AFIzgD6vPiKIHXuRarF1n2+SEwZ0zfS9QdpJm8Jpitb8aiCL TuBX28/MZu5EvrCYqisCsJPjViDRktsFUo3Z3P10iFuY/a9fvj5DAUB9jY9KuLvxJlw7 yy1g== X-Gm-Message-State: APjAAAVpe/jO+rcXDKZCJYpN1aZZ4NGgMMOr7QKL980hiU7Svz3hausX B7cJpTCjQ8yLpv/tR8jE+ZOcXvzA5hG6XdGS+AcCYezW X-Google-Smtp-Source: APXvYqx6Rks9sj/FFSVdyOHGG6RPidSc2/JI0HCInqCNpGUtsylXEr3r9D0gnXHYu8hvyvpP4QUNYwMUFP65Fy1F5js= X-Received: by 2002:aed:3c45:: with SMTP id u5mr10248198qte.175.1566666151939; Sat, 24 Aug 2019 10:02:31 -0700 (PDT) MIME-Version: 1.0 References: <1ed2692e-9964-58f7-5af9-08fadf65dec7@protected-networks.net> In-Reply-To: <1ed2692e-9964-58f7-5af9-08fadf65dec7@protected-networks.net> From: Warner Losh Date: Sat, 24 Aug 2019 11:02:20 -0600 Message-ID: Subject: Re: SVN r351457 breaks drm-current To: Michael Butler Cc: Konstantin Belousov , freebsd-current X-Rspamd-Queue-Id: 46G4MF4NTWz3QPj X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=AF/TlPBJ; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::835) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-4.93 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.99)[-0.992,0]; RCVD_IN_DNSWL_NONE(0.00)[5.3.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.93)[ip: (-9.41), ipnet: 2607:f8b0::/32(-2.87), asn: 15169(-2.34), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Aug 2019 17:02:34 -0000 forward declaring struct pcpu; in md_var.h "fixes" this, but I'm not sure that's the right fix. Warner On Sat, Aug 24, 2019 at 10:35 AM Michael Butler wrote: > As follows .. > > Building > > /usr/obj/usr/src/amd64.amd64/sys/TOSHI/modules/usr/local/sys/modules/drm-current-kmod/linuxkpi/linux_compat.o > --- linux_compat.o --- > In file included from > > /usr/local/sys/modules/drm-current-kmod/linuxkpi/gplv2/src/linux_compat.c:5: > ./machine/md_var.h:61:34: error: declaration of 'struct pcpu' will not > be visible outside of this function [-Werror,-Wvisibility] > void amd64_bsp_pcpu_init1(struct pcpu *pc); > ^ > ./machine/md_var.h:63:32: error: declaration of 'struct pcpu' will not > be visible outside of this function [-Werror,-Wvisibility] > void amd64_bsp_ist_init(struct pcpu *pc); > ^ > > imb > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >