Date: Fri, 2 Mar 2012 14:03:00 -0800 (PST) From: Doug Ambrisko <ambrisko@ambrisko.com> To: sbruno@freebsd.org Cc: hackers@freebsd.org Subject: Re: [patch] Disable bios probe if acpi is enabled Message-ID: <201203022203.q22M30eI071370@ambrisko.com> In-Reply-To: <1330720724.5391.2.camel@powernoodle-l7.corp.yahoo.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Sean Bruno writes:
| I'm noting that newer machines are completely hosed if we attempt to
| probe for bios values. I'm proposing this change.
|
| -bash-4.2$ p4 diff -du //depot/yahoo/ybsd_7/src/sys/i386/i386/bios.c
| --- //depot/yahoo/ybsd_7/src/sys/i386/i386/bios.c 2011-09-16
| 22:47:30.000000000 0000
| +++ /home/seanbru/ybsd_7/src/sys/i386/i386/bios.c 2011-09-16
| 22:47:30.000000000 0000
| @@ -84,6 +84,12 @@
| char *p;
|
| /*
| + * Don't do bios probing if acpi is enabled, its
| + * pointless and breaks on newer systems
| + */
| + if (!resource_disabled("acpi", 0))
| + return;
| + /*
| * BIOS32 Service Directory, PCI BIOS
| */
|
That seems reasonable to me.
Doug A.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201203022203.q22M30eI071370>