From owner-cvs-all@FreeBSD.ORG Sun Jul 3 01:26:15 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.ORG Delivered-To: cvs-all@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9400216B322; Sun, 3 Jul 2005 01:01:40 +0000 (GMT) (envelope-from ps@mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 063504430F; Sun, 3 Jul 2005 00:50:06 +0000 (GMT) (envelope-from ps@mu.org) Received: by elvis.mu.org (Postfix, from userid 1000) id ED7C06EA47; Sat, 2 Jul 2005 17:40:33 -0700 (PDT) X-Original-To: ps@mu.org Delivered-To: ps@mu.org Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by elvis.mu.org (Postfix) with ESMTP id 2CC245C9A7 for ; Sun, 20 Feb 2005 15:17:24 -0800 (PST) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id DC67E57883 for ; Sun, 20 Feb 2005 23:17:22 +0000 (GMT) (envelope-from owner-src-committers@FreeBSD.org) Received: by hub.freebsd.org (Postfix) id E5F4116A537; Sun, 20 Feb 2005 23:17:18 +0000 (GMT) Delivered-To: ps@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 538) id 6F14C16A4D0; Sun, 20 Feb 2005 23:17:16 +0000 (GMT) Delivered-To: src-committers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7253B16A4CE; Sun, 20 Feb 2005 23:17:15 +0000 (GMT) Received: from VARK.MIT.EDU (VARK.MIT.EDU [18.95.3.179]) by mx1.FreeBSD.org (Postfix) with ESMTP id E0AA743D5D; Sun, 20 Feb 2005 23:17:14 +0000 (GMT) (envelope-from das@FreeBSD.ORG) Received: from VARK.MIT.EDU (localhost [127.0.0.1]) by VARK.MIT.EDU (8.13.3/8.13.1) with ESMTP id j1KNHB1W008258; Sun, 20 Feb 2005 18:17:11 -0500 (EST) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.MIT.EDU (8.13.3/8.13.1/Submit) id j1KNHBRG008257; Sun, 20 Feb 2005 18:17:11 -0500 (EST) (envelope-from das@FreeBSD.ORG) From: David Schultz To: Xin LI Message-ID: <20050220231711.GA8172@VARK.MIT.EDU> Mail-Followup-To: Xin LI , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200502200802.j1K82G2M003470@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200502200802.j1K82G2M003470@repoman.freebsd.org> Sender: owner-src-committers@FreeBSD.org Precedence: bulk X-Loop: FreeBSD.ORG X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on elvis.mu.org X-Spam-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00, SARE_SUB_GAPPY_3 autolearn=no version=3.0.2 X-Spam-Level: Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sbin/fsck_ffs fsck.h pass5.c src/sys/ufs/ffs ffs_alloc.c ffs_softdep.c fs.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Sun, 03 Jul 2005 01:26:15 -0000 X-Original-Date: Sun, 20 Feb 2005 18:17:11 -0500 X-List-Received-Date: Sun, 03 Jul 2005 01:26:15 -0000 On Sun, Feb 20, 2005, Xin LI wrote: > delphij 2005-02-20 08:02:16 UTC > > FreeBSD src repository > > Modified files: > sbin/fsck_ffs fsck.h pass5.c > sys/ufs/ffs ffs_alloc.c ffs_softdep.c fs.h > Log: > The recomputation of file system summary at mount time can be a > very slow process, especially for large file systems that is just > recovered from a crash. > > Since the summary is already re-sync'ed every 30 second, we will > not lag behind too much after a crash. With this consideration > in mind, it is more reasonable to transfer the responsibility to > background fsck, to reduce the delay after a crash. I'm not sure that I completely buy this explanation. If an application has a 1 GB temporary file open and unlinked at the time of the crash, then upon reboot, this change will make it seem as though I have 1 GB less space than I really do. This could lead to spurious disk full errors. (Or will that happen anyway if bgfsck hasn't recomputed all the free block bitmaps yet?) I don't mean to suggest that this is a bad idea; to the contrary, I think it's a great idea. But unless I'm missing something, it has larger adverse effects than claimed in the commit message. FWIW, I run bgfsck on my development box once a month from a cron job, rather than after every crash. As long as there's free space and no bugs in the filesystem or I/O system (okay, a big assumption), this doesn't hurt anything and saves me lots of time.