From owner-cvs-all Mon Jun 4 18:29:26 2001 Delivered-To: cvs-all@freebsd.org Received: from mailgate.originative.co.uk (mailgate.originative.co.uk [62.232.68.68]) by hub.freebsd.org (Postfix) with ESMTP id AA04B37B401; Mon, 4 Jun 2001 18:29:18 -0700 (PDT) (envelope-from paul@freebsd-services.co.uk) Received: from lobster.originative.co.uk (lobster [62.232.68.81]) by mailgate.originative.co.uk (Postfix) with ESMTP id F00B71D1A2; Tue, 5 Jun 2001 02:29:16 +0100 (BST) Date: Tue, 05 Jun 2001 02:33:53 +0100 From: Paul Richards To: Dag-Erling Smorgrav , Paul Richards Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/mailwrapper mailwrapper.c Message-ID: <57630000.991704833@lobster.originative.co.uk> In-Reply-To: X-Mailer: Mulberry/2.0.8 (Linux/x86 Demo) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --On Tuesday, June 05, 2001 02:02:59 +0200 Dag-Erling Smorgrav wrote: > Paul Richards writes: >> Log: >> You can't free a string and then use it as the error message to >> errx. Instead use warn to print the string, then cleanup and exit >> normally. > > If you're going to exit() anyway, you don't need to bother freeing the > string. That would be a pretty sloppy coding habit in general which is why I decided against it. I did think about it in this case though because errx was the last consumer of the string. Paul. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message